<p>Bill XIE has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21673">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">device/dram/ddr2.c: fix a minor regression introduced earlier<br><br>A regression is hidden in Change<br>I091121a5d08159cea4befdedb5f3a92ce132c6e5, which breaks the build<br>procedure when CONFIG_DEBUG_RAM_SETUP is set.<br><br>Maybe it had better implement "printram" and the like as inline<br>functions instead of macros.<br><br>Change-Id: If956435bd0c39b1f3e722c2cfc48d2d0f35abc9b<br>Signed-off-by: Bill XIE <persmule@gmail.com><br>---<br>M src/device/dram/ddr2.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/21673/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c<br>index d524238..e06e342 100644<br>--- a/src/device/dram/ddr2.c<br>+++ b/src/device/dram/ddr2.c<br>@@ -547,7 +547,7 @@<br>          ret = SPD_STATUS_INVALID_FIELD;<br>       dimm->flags.self_refresh = (spd[12] >> 7) & 1;<br>   printram("The assembly supports self refresh: %s\n",<br>-               dimm->flags.self_refresh ? "true", "false");<br>+           dimm->flags.self_refresh ? "true" : "false");<br> <br>      /* Number of PLLs on DIMM */<br>  if (dimm->rev >= 0x11)<br></pre><p>To view, visit <a href="https://review.coreboot.org/21673">change 21673</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21673"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If956435bd0c39b1f3e722c2cfc48d2d0f35abc9b </div>
<div style="display:none"> Gerrit-Change-Number: 21673 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>