<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21658">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">console/init.c: Don't fetch console loglevel from cmos in romstage<br><br>Runtime console loglevel is not supported in romstage and the<br>get_option function has printk() in it which should not be used before<br>hardware is initialized.<br><br>Change-Id: I2fbf9febd695b012b8b4f04019fba806ac3181cf<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/console/init.c<br>1 file changed, 4 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/21658/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/console/init.c b/src/console/init.c<br>index c1565a4..be99565 100644<br>--- a/src/console/init.c<br>+++ b/src/console/init.c<br>@@ -39,21 +39,15 @@<br>   return console_loglevel;<br> }<br> <br>-static inline void set_log_level(int new_level)<br>-{<br>-        if (CONSOLE_LEVEL_CONST)<br>-             return;<br>-<br>-   console_loglevel = new_level;<br>-}<br>-<br> static void init_log_level(void)<br> {<br>   int debug_level = CONFIG_DEFAULT_CONSOLE_LOGLEVEL;<br> <br>-        get_option(&debug_level, "debug_level");<br>+       if (CONSOLE_LEVEL_CONST)<br>+             return;<br> <br>-   set_log_level(debug_level);<br>+  get_option(&debug_level, "debug_level");<br>+       console_loglevel = debug_level;<br> }<br> <br> int console_log_level(int msg_level)<br></pre><p>To view, visit <a href="https://review.coreboot.org/21658">change 21658</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21658"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2fbf9febd695b012b8b4f04019fba806ac3181cf </div>
<div style="display:none"> Gerrit-Change-Number: 21658 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>