<p>Jonathan Neuschäfer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21653">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">smbus: Fix a typo ("Set the device I'm talking too")<br><br>Change-Id: Ia14bbdfe973cec4b366879cd2ed5602b43754260<br>Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net><br>---<br>M src/soc/amd/stoneyridge/smbus.c<br>M src/soc/intel/broadwell/smbus_common.c<br>M src/soc/intel/common/block/smbus/smbuslib.c<br>M src/soc/intel/fsp_broadwell_de/smbus_common.c<br>M src/soc/intel/sch/smbus.h<br>M src/southbridge/amd/agesa/hudson/smbus.c<br>M src/southbridge/amd/amd8111/amd8111_smbus.h<br>M src/southbridge/amd/cimx/sb700/smbus.c<br>M src/southbridge/amd/cimx/sb800/smbus.c<br>M src/southbridge/amd/cimx/sb900/smbus.c<br>M src/southbridge/amd/pi/hudson/smbus.c<br>M src/southbridge/amd/sb600/smbus.c<br>M src/southbridge/amd/sb700/smbus.c<br>M src/southbridge/amd/sb800/smbus.c<br>M src/southbridge/broadcom/bcm5785/smbus.h<br>M src/southbridge/intel/common/smbus.c<br>M src/southbridge/nvidia/mcp55/smbus.h<br>M src/southbridge/sis/sis966/early_smbus.c<br>M util/romcc/tests/raminit_test.c<br>M util/romcc/tests/raminit_test1.c<br>M util/romcc/tests/raminit_test2.c<br>M util/romcc/tests/simple_test4.c<br>M util/romcc/tests/simple_test5.c<br>M util/romcc/tests/simple_test6.c<br>M util/romcc/tests/simple_test61.c<br>25 files changed, 74 insertions(+), 74 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/21653/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/smbus.c b/src/soc/amd/stoneyridge/smbus.c<br>index aef3edf..b216f1e 100644<br>--- a/src/soc/amd/stoneyridge/smbus.c<br>+++ b/src/soc/amd/stoneyridge/smbus.c<br>@@ -59,7 +59,7 @@<br> if (smbus_wait_until_ready(smbus_io_base) < 0)<br> return -2; /* not ready */<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -87,7 +87,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -113,7 +113,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -142,7 +142,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/soc/intel/broadwell/smbus_common.c b/src/soc/intel/broadwell/smbus_common.c<br>index 29b7dbb..bec988f 100644<br>--- a/src/soc/intel/broadwell/smbus_common.c<br>+++ b/src/soc/intel/broadwell/smbus_common.c<br>@@ -68,7 +68,7 @@<br> /* Setup transaction */<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>@@ -112,7 +112,7 @@<br> /* Setup transaction */<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c<br>index a865abf..27b4ad5 100644<br>--- a/src/soc/intel/common/block/smbus/smbuslib.c<br>+++ b/src/soc/intel/common/block/smbus/smbuslib.c<br>@@ -58,7 +58,7 @@<br> /* Setup transaction */<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>@@ -103,7 +103,7 @@<br> /* Setup transaction */<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>diff --git a/src/soc/intel/fsp_broadwell_de/smbus_common.c b/src/soc/intel/fsp_broadwell_de/smbus_common.c<br>index 26bb4fd..20e8f09 100644<br>--- a/src/soc/intel/fsp_broadwell_de/smbus_common.c<br>+++ b/src/soc/intel/fsp_broadwell_de/smbus_common.c<br>@@ -67,7 +67,7 @@<br> /* Setup transaction */<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>@@ -113,7 +113,7 @@<br> /* Setup transaction */<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>diff --git a/src/soc/intel/sch/smbus.h b/src/soc/intel/sch/smbus.h<br>index e34ca52..19d70b6 100644<br>--- a/src/soc/intel/sch/smbus.h<br>+++ b/src/soc/intel/sch/smbus.h<br>@@ -59,7 +59,7 @@<br> /* Setup transaction */<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & (~1), smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>diff --git a/src/southbridge/amd/agesa/hudson/smbus.c b/src/southbridge/amd/agesa/hudson/smbus.c<br>index 9aa152b..ce0361a 100644<br>--- a/src/southbridge/amd/agesa/hudson/smbus.c<br>+++ b/src/southbridge/amd/agesa/hudson/smbus.c<br>@@ -64,7 +64,7 @@<br> return -2; /* not ready */<br> }<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -94,7 +94,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -122,7 +122,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -153,7 +153,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/amd/amd8111/amd8111_smbus.h b/src/southbridge/amd/amd8111/amd8111_smbus.h<br>index f82bb19..6b2459f 100644<br>--- a/src/southbridge/amd/amd8111/amd8111_smbus.h<br>+++ b/src/southbridge/amd/amd8111/amd8111_smbus.h<br>@@ -62,7 +62,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outw(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> /* set the command/address... */<br> outb(0, smbus_io_base + SMBHSTCMD);<br>@@ -107,7 +107,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outw(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> /* set the command/address... */<br> outb(0, smbus_io_base + SMBHSTCMD);<br>@@ -150,7 +150,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outw(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> /* set the command/address... */<br> outb(address & 0xFF, smbus_io_base + SMBHSTCMD);<br>@@ -195,7 +195,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outw(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> outb(address & 0xFF, smbus_io_base + SMBHSTCMD);<br> /* set up for a byte data write */ /* FIXME */<br>@@ -235,7 +235,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outw(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> /* set the command/address... */<br> outb(cmd & 0xFF, smbus_io_base + SMBHSTCMD);<br>@@ -290,7 +290,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outw(inw(smbus_io_base + SMBGCTL) & ~((1<<10)|(1<<9)|(1<<8)|(1<<4)), smbus_io_base + SMBGCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outw(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> /* set the command/address... */<br> outb(cmd & 0xFF, smbus_io_base + SMBHSTCMD);<br>diff --git a/src/southbridge/amd/cimx/sb700/smbus.c b/src/southbridge/amd/cimx/sb700/smbus.c<br>index 8ae6d3b..9d78cd0 100644<br>--- a/src/southbridge/amd/cimx/sb700/smbus.c<br>+++ b/src/southbridge/amd/cimx/sb700/smbus.c<br>@@ -67,7 +67,7 @@<br> }<br> <br> printk(BIOS_SPEW, "SB700 - Smbus.c - do_smbus_recv_byte - Start.\n");<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -99,7 +99,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -128,7 +128,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -160,7 +160,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/amd/cimx/sb800/smbus.c b/src/southbridge/amd/cimx/sb800/smbus.c<br>index 80395f1..53b0a13 100644<br>--- a/src/southbridge/amd/cimx/sb800/smbus.c<br>+++ b/src/southbridge/amd/cimx/sb800/smbus.c<br>@@ -68,7 +68,7 @@<br> }<br> <br> printk(BIOS_DEBUG, "SB800 - Smbus.c - do_smbus_recv_byte - Start.\n");<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -101,7 +101,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -131,7 +131,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -164,7 +164,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/amd/cimx/sb900/smbus.c b/src/southbridge/amd/cimx/sb900/smbus.c<br>index 7d11898..aaa0968 100644<br>--- a/src/southbridge/amd/cimx/sb900/smbus.c<br>+++ b/src/southbridge/amd/cimx/sb900/smbus.c<br>@@ -68,7 +68,7 @@<br> }<br> <br> printk(BIOS_INFO, "SB900 - Smbus.c - do_smbus_recv_byte - Start.\n");<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -101,7 +101,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -131,7 +131,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -164,7 +164,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/amd/pi/hudson/smbus.c b/src/southbridge/amd/pi/hudson/smbus.c<br>index 9aa152b..ce0361a 100644<br>--- a/src/southbridge/amd/pi/hudson/smbus.c<br>+++ b/src/southbridge/amd/pi/hudson/smbus.c<br>@@ -64,7 +64,7 @@<br> return -2; /* not ready */<br> }<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -94,7 +94,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -122,7 +122,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -153,7 +153,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/amd/sb600/smbus.c b/src/southbridge/amd/sb600/smbus.c<br>index 6c61cf0..990098f 100644<br>--- a/src/southbridge/amd/sb600/smbus.c<br>+++ b/src/southbridge/amd/sb600/smbus.c<br>@@ -64,7 +64,7 @@<br> return -2; /* not ready */<br> }<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -94,7 +94,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -121,7 +121,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -151,7 +151,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/amd/sb700/smbus.c b/src/southbridge/amd/sb700/smbus.c<br>index 373c339..58bbe4c 100644<br>--- a/src/southbridge/amd/sb700/smbus.c<br>+++ b/src/southbridge/amd/sb700/smbus.c<br>@@ -111,7 +111,7 @@<br> return -2; /* not ready */<br> }<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -141,7 +141,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -168,7 +168,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -198,7 +198,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/amd/sb800/smbus.c b/src/southbridge/amd/sb800/smbus.c<br>index d9bb746..89244f4 100644<br>--- a/src/southbridge/amd/sb800/smbus.c<br>+++ b/src/southbridge/amd/sb800/smbus.c<br>@@ -67,7 +67,7 @@<br> return -2; /* not ready */<br> }<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -97,7 +97,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -125,7 +125,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -156,7 +156,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/broadcom/bcm5785/smbus.h b/src/southbridge/broadcom/bcm5785/smbus.h<br>index 76c593b..8ebe203 100644<br>--- a/src/southbridge/broadcom/bcm5785/smbus.h<br>+++ b/src/southbridge/broadcom/bcm5785/smbus.h<br>@@ -85,7 +85,7 @@<br> return -2; // not ready<br> }<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -115,7 +115,7 @@<br> /* set the command... */<br> outb(val, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1)|0 , smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -142,7 +142,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBHSTADDR);<br> <br> byte = inb(smbus_io_base + SMBHSTCTRL);<br>@@ -172,7 +172,7 @@<br> /* set the command/address... */<br> outb(address & 0xff, smbus_io_base + SMBHSTCMD);<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1)|0 , smbus_io_base + SMBHSTADDR);<br> <br> /* output value */<br>diff --git a/src/southbridge/intel/common/smbus.c b/src/southbridge/intel/common/smbus.c<br>index e6b1188..99608dc 100644<br>--- a/src/southbridge/intel/common/smbus.c<br>+++ b/src/southbridge/intel/common/smbus.c<br>@@ -115,7 +115,7 @@<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN,<br> smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>@@ -164,7 +164,7 @@<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN,<br> smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(address & 0xff, smbus_base + SMBHSTCMD);<br>@@ -217,7 +217,7 @@<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN,<br> smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(cmd & 0xff, smbus_base + SMBHSTCMD);<br>@@ -292,7 +292,7 @@<br> /* Disable interrupts */<br> outb(inb(smbus_base + SMBHSTCTL) & ~SMBHSTCNT_INTREN,<br> smbus_base + SMBHSTCTL);<br>- /* Set the device I'm talking too */<br>+ /* Set the device I'm talking to */<br> outb(((device & 0x7f) << 1) & ~0x01, smbus_base + SMBXMITADD);<br> /* Set the command/address... */<br> outb(cmd & 0xff, smbus_base + SMBHSTCMD);<br>diff --git a/src/southbridge/nvidia/mcp55/smbus.h b/src/southbridge/nvidia/mcp55/smbus.h<br>index a7a6679..a588a09 100644<br>--- a/src/southbridge/nvidia/mcp55/smbus.h<br>+++ b/src/southbridge/nvidia/mcp55/smbus.h<br>@@ -56,7 +56,7 @@<br> unsigned char global_status_register;<br> unsigned char byte;<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBXMITADD);<br> smbus_delay();<br> <br>@@ -90,7 +90,7 @@<br> outb(val, smbus_io_base + SMBHSTCMD);<br> smbus_delay();<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD);<br> smbus_delay();<br> <br>@@ -114,7 +114,7 @@<br> unsigned char global_status_register;<br> unsigned char byte;<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBXMITADD);<br> smbus_delay();<br> /* set the command/address... */<br>@@ -148,7 +148,7 @@<br> outb(val, smbus_io_base + SMBHSTDAT0);<br> smbus_delay();<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD);<br> smbus_delay();<br> <br>diff --git a/src/southbridge/sis/sis966/early_smbus.c b/src/southbridge/sis/sis966/early_smbus.c<br>index 99f8bd4..3c8998e 100644<br>--- a/src/southbridge/sis/sis966/early_smbus.c<br>+++ b/src/southbridge/sis/sis966/early_smbus.c<br>@@ -62,7 +62,7 @@<br> unsigned char global_status_register;<br> unsigned char byte;<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1)|1 , smbus_io_base + SMBXMITADD);<br> smbus_delay();<br> <br>@@ -97,7 +97,7 @@<br> outb(val, smbus_io_base + SMBHSTCMD);<br> smbus_delay();<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD);<br> smbus_delay();<br> <br>@@ -161,7 +161,7 @@<br> outb(val, smbus_io_base + SMBHSTDAT0);<br> smbus_delay();<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 0, smbus_io_base + SMBXMITADD);<br> smbus_delay();<br> <br>diff --git a/util/romcc/tests/raminit_test.c b/util/romcc/tests/raminit_test.c<br>index 569d75b..b1baf7e 100644<br>--- a/util/romcc/tests/raminit_test.c<br>+++ b/util/romcc/tests/raminit_test.c<br>@@ -314,7 +314,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD);<br>diff --git a/util/romcc/tests/raminit_test1.c b/util/romcc/tests/raminit_test1.c<br>index 569d75b..b1baf7e 100644<br>--- a/util/romcc/tests/raminit_test1.c<br>+++ b/util/romcc/tests/raminit_test1.c<br>@@ -314,7 +314,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD);<br>diff --git a/util/romcc/tests/raminit_test2.c b/util/romcc/tests/raminit_test2.c<br>index d20ae6d..c5b366f 100644<br>--- a/util/romcc/tests/raminit_test2.c<br>+++ b/util/romcc/tests/raminit_test2.c<br>@@ -314,7 +314,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD);<br>diff --git a/util/romcc/tests/simple_test4.c b/util/romcc/tests/simple_test4.c<br>index 2ac6a4d..bd3f52a 100644<br>--- a/util/romcc/tests/simple_test4.c<br>+++ b/util/romcc/tests/simple_test4.c<br>@@ -313,7 +313,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD);<br>@@ -383,7 +383,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_HSTCTL) & (~1), SMBUS_IO_HSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_HSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_HSTCMD);<br>diff --git a/util/romcc/tests/simple_test5.c b/util/romcc/tests/simple_test5.c<br>index 976fa3d..e744f8f 100644<br>--- a/util/romcc/tests/simple_test5.c<br>+++ b/util/romcc/tests/simple_test5.c<br>@@ -141,7 +141,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD);<br>@@ -211,7 +211,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_HSTCTL) & (~1), SMBUS_IO_HSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_HSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_HSTCMD);<br>diff --git a/util/romcc/tests/simple_test6.c b/util/romcc/tests/simple_test6.c<br>index 147614e..8aee0cd 100644<br>--- a/util/romcc/tests/simple_test6.c<br>+++ b/util/romcc/tests/simple_test6.c<br>@@ -137,7 +137,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_BASE + SMBHSTCTL) & (~1), SMBUS_IO_BASE + SMBHSTCTL);<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_BASE + SMBHSTADD);<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_BASE + SMBHSTCMD);<br>@@ -207,7 +207,7 @@<br> /* setup transaction */<br> /* disable interrupts */<br> outb(inb(SMBUS_IO_HSTCTL) & (~1), SMBUS_IO_HSTCTL); /* 3 */<br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> outb(((device & 0x7f) << 1) | 1, SMBUS_IO_HSTADD); /* 1 + 3 */<br> /* set the command/address... */<br> outb(address & 0xFF, SMBUS_IO_HSTCMD); /* 1 + 3 */<br>diff --git a/util/romcc/tests/simple_test61.c b/util/romcc/tests/simple_test61.c<br>index 2b235cc..c0446e2 100644<br>--- a/util/romcc/tests/simple_test61.c<br>+++ b/util/romcc/tests/simple_test61.c<br>@@ -14,7 +14,7 @@<br> /* 0 == None, 1 == Parity, 2 == ECC */<br> if (byte != 2) continue;<br> <br>- /* set the device I'm talking too */<br>+ /* set the device I'm talking to */<br> __builtin_outb(device, 0x1004);<br> <br> /* poll for transaction completion */<br></pre><p>To view, visit <a href="https://review.coreboot.org/21653">change 21653</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21653"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia14bbdfe973cec4b366879cd2ed5602b43754260 </div>
<div style="display:none"> Gerrit-Change-Number: 21653 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>