<p>Micha? ?ygowski has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21632">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add disable SPD option to coreboot menuconfig.<br><br>Running memtest86+ with RAM SPD retrieval on mainboards and<br>chipsets that do not support retrieving SPD info leads to<br>unexpected behaviours or freezes platforms (e.g. APU2). This<br>option allows to run Memtest86+ on such platforms.<br><br>Change-Id: I72774f296bb977ddb7aedd77ccbd6f1ad6b30916<br>Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com><br>---<br>M payloads/Kconfig<br>M payloads/external/Makefile.inc<br>M payloads/external/Memtest86Plus/Makefile<br>3 files changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/21632/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/payloads/Kconfig b/payloads/Kconfig<br>index bb9348b..b8f8b5c 100644<br>--- a/payloads/Kconfig<br>+++ b/payloads/Kconfig<br>@@ -109,6 +109,15 @@<br>     non-reproducible, as it can fetch different code each time.<br> endchoice<br> <br>+config MEMTEST_SPD<br>+    bool "Disable retrieving SPD info"<br>+ depends on MEMTEST_SECONDARY_PAYLOAD<br>+ help<br>+   Disables retrieving RAM SPD info in Memtest86+.<br>+<br>+   Some chipsets and mainboards does not support this feature and it<br>+    should be disabled in Memtest86+ to avoid unwanted behaviour.<br>+<br> config NVRAMCUI_SECONDARY_PAYLOAD<br>        bool "Load nvramcui as a secondary payload"<br>         default n<br>diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc<br>index 0a9b3d6..bcd5911 100644<br>--- a/payloads/external/Makefile.inc<br>+++ b/payloads/external/Makefile.inc<br>@@ -201,6 +201,7 @@<br>               AS="$(AS_x86_32)" \<br>                 CONFIG_MEMTEST_MASTER=$(CONFIG_MEMTEST_MASTER) \<br>              CONFIG_MEMTEST_STABLE=$(CONFIG_MEMTEST_STABLE) \<br>+             CONFIG_MEMTEST_SPD=$(CONFIG_MEMTEST_SPD) \<br>            $(MEMTEST_SERIAL_OPTIONS) \<br>           MFLAGS= MAKEFLAGS=<br> <br>diff --git a/payloads/external/Memtest86Plus/Makefile b/payloads/external/Memtest86Plus/Makefile<br>index 2136495..a8fd7cf 100644<br>--- a/payloads/external/Memtest86Plus/Makefile<br>+++ b/payloads/external/Memtest86Plus/Makefile<br>@@ -43,7 +43,9 @@<br> <br> build: checkout<br>        echo "    MAKE       $(project_name) $(NAME-y)"<br>-    $(MAKE) -C $(project_dir) all<br>+        if [ "$(CONFIG_MEMTEST_SPD)" = "y" ]; then \<br>+             $(MAKE) -C $(project_dir) CB_NOSPD=1 all; \<br>+  else    $(MAKE) -C $(project_dir) all; fi<br> <br> clean:<br>         test -d $(project_dir) && $(MAKE) -C $(project_dir) clean || exit 0<br></pre><p>To view, visit <a href="https://review.coreboot.org/21632">change 21632</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21632"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I72774f296bb977ddb7aedd77ccbd6f1ad6b30916 </div>
<div style="display:none"> Gerrit-Change-Number: 21632 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Micha? ?ygowski <michal.zygowski@3mdeb.com> </div>