<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21620">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">device/dram/ddr2.c: Be more lax about bit7 for tRR byte in SPD<br><br>At least one dimm was found to have an SPD with valid checksum (so<br>otherwise sane) but without bit7 set.<br><br>Change-Id: I091121a5d08159cea4befdedb5f3a92ce132c6e5<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/device/dram/ddr2.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/21620/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c<br>index 6f43563..0a6574f 100644<br>--- a/src/device/dram/ddr2.c<br>+++ b/src/device/dram/ddr2.c<br>@@ -188,6 +188,12 @@<br>  */<br> static int spd_decode_tRR_time(u32 *tRR, u8 c)<br> {<br>+ if (!(c & (1 << 7))) {<br>+             printk(BIOS_DEBUG, "SPD byte12 (tRR) bit7 not set,"<br>+                        " ignoring...");<br>+           c |= (1 << 7);<br>+ }<br>+<br>  switch (c) {<br>  default:<br>              printk(BIOS_WARNING, "Invalid tRR value 0x%x\n", c);<br></pre><p>To view, visit <a href="https://review.coreboot.org/21620">change 21620</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21620"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I091121a5d08159cea4befdedb5f3a92ce132c6e5 </div>
<div style="display:none"> Gerrit-Change-Number: 21620 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>