<p>Jonathan Neuschäfer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21590">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use stopwatch_wait_until_expired where applicable<br><br>Change-Id: I4d6c6810b91294a7e401a4a1a446218c04c98e55<br>Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net><br>---<br>M src/drivers/i2c/rx6110sa/rx6110sa.c<br>M src/ec/google/chromeec/ec_spi.c<br>M src/lib/timer.c<br>M src/mainboard/google/oak/romstage.c<br>M src/mainboard/siemens/mc_apl1/mainboard.c<br>5 files changed, 7 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/21590/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c<br>index aad1097..69ea9fe 100644<br>--- a/src/drivers/i2c/rx6110sa/rx6110sa.c<br>+++ b/src/drivers/i2c/rx6110sa/rx6110sa.c<br>@@ -149,8 +149,7 @@<br>      * Take the needed delay after a reset sequence into account before the<br>        * VLF-bit can be cleared.<br>     */<br>-  while (!stopwatch_expired(&sw))<br>-          ;<br>+    stopwatch_wait_until_expired(&sw);<br>        flags &= ~VLF_BIT;<br>        rx6110sa_write(dev, FLAG_REGISTER, flags);<br> <br>diff --git a/src/ec/google/chromeec/ec_spi.c b/src/ec/google/chromeec/ec_spi.c<br>index 810979e..3611814 100644<br>--- a/src/ec/google/chromeec/ec_spi.c<br>+++ b/src/ec/google/chromeec/ec_spi.c<br>@@ -51,8 +51,9 @@<br>         struct spi_slave *slave = (struct spi_slave *)context;<br>        int ret = 0;<br> <br>-      while (!stopwatch_expired(&cs_cooldown_sw))<br>-              /* Wait minimum delay between CS assertions. */;<br>+     /* Wait minimum delay between CS assertions. */<br>+      stopwatch_wait_until_expired(&cs_cooldown_sw);<br>+<br>         spi_claim_bus(slave);<br> <br>       /* Allow EC to ramp up clock after being awaken.<br>diff --git a/src/lib/timer.c b/src/lib/timer.c<br>index 58d32ee..adc0d07 100644<br>--- a/src/lib/timer.c<br>+++ b/src/lib/timer.c<br>@@ -34,7 +34,5 @@<br>             return;<br> <br>    stopwatch_init_usecs_expire(&sw, usec);<br>-<br>-       while (!stopwatch_expired(&sw))<br>-          ;<br>+    stopwatch_wait_until_expired(&sw);<br> }<br>diff --git a/src/mainboard/google/oak/romstage.c b/src/mainboard/google/oak/romstage.c<br>index a92e4fb..1f56547 100644<br>--- a/src/mainboard/google/oak/romstage.c<br>+++ b/src/mainboard/google/oak/romstage.c<br>@@ -55,8 +55,7 @@<br>    /* init memory */<br>     mt_mem_init(get_sdram_config());<br> <br>-  while (!stopwatch_expired(&sw))<br>-          ;<br>+    stopwatch_wait_until_expired(&sw);<br> <br>     /* Set to maximum frequency */<br>        if (board_id() + CONFIG_BOARD_ID_ADJUSTMENT < 5)<br>diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c<br>index fb849f9..f77ef75 100644<br>--- a/src/mainboard/siemens/mc_apl1/mainboard.c<br>+++ b/src/mainboard/siemens/mc_apl1/mainboard.c<br>@@ -165,8 +165,7 @@<br>         stopwatch_init_msecs_expire(&sw, (legacy_delay - us_since_boot) / 1000);<br>  printk(BIOS_NOTICE, "Wait remaining %d of %d us for legacy devices...",<br>                     legacy_delay - us_since_boot, legacy_delay);<br>- while (!stopwatch_expired(&sw))<br>-          ;<br>+    stopwatch_wait_until_expired(&sw);<br>        printk(BIOS_NOTICE, "done!\n");<br> }<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/21590">change 21590</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21590"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4d6c6810b91294a7e401a4a1a446218c04c98e55 </div>
<div style="display:none"> Gerrit-Change-Number: 21590 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>