<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21563">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/i945: Update comments<br><br>i945M supports two DIMMs, however<br>i945G* supports four DIMMs and have<br>their SPD at 0x50/0x51/0x52/0x53.<br><br>Change-Id: If4c7aa4723c0a9715e2931e40a041bfcfd55b8b6<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/northbridge/intel/i945/raminit.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/21563/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c<br>index f10f108..14960b8 100644<br>--- a/src/northbridge/intel/i945/raminit.c<br>+++ b/src/northbridge/intel/i945/raminit.c<br>@@ -324,7 +324,7 @@<br>         int i;<br> <br>     /**<br>-   * i945 supports two DIMMs, in two configurations:<br>+    * i945M supports two DIMMs, in two configurations:<br>    *<br>     * - single channel with two DIMMs<br>     * - dual channel with one DIMM per channel<br>@@ -332,6 +332,8 @@<br>       * In practice dual channel mainboards have their SPD at 0x50/0x52<br>     * whereas single channel configurations have their SPD at 0x50/0x51.<br>          *<br>+    * i945G* supports four DIMMs, and have their SPD at 0x50/0x51/0x52/0x53.<br>+     *<br>     * The capability register knows a lot about the channel configuration<br>         * but for now we stick with the information we gather via SPD.<br>        */<br></pre><p>To view, visit <a href="https://review.coreboot.org/21563">change 21563</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21563"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If4c7aa4723c0a9715e2931e40a041bfcfd55b8b6 </div>
<div style="display:none"> Gerrit-Change-Number: 21563 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>