<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21492">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/stoneyridge: Remove PSP BAR init from cpu init<br><br>Remove the step of setting PSP BAR3 from cpu_dev_ops .init.  The<br>BAR is configured in romstage by AmdInitPost().<br><br>Change-Id: I7e77fad3abdcb6482f1b9d849e5922a426dff5f5<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/stoneyridge/model_15_init.c<br>1 file changed, 0 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21492/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/model_15_init.c b/src/soc/amd/stoneyridge/model_15_init.c<br>index a46f322..631e89c 100644<br>--- a/src/soc/amd/stoneyridge/model_15_init.c<br>+++ b/src/soc/amd/stoneyridge/model_15_init.c<br>@@ -30,23 +30,6 @@<br> #include <cpu/amd/amdfam15.h><br> #include <arch/acpi.h><br> <br>-#include <amdlib.h><br>-#include <PspBaseLib.h><br>-<br>-void PSPProgBar3Msr(void *Buffer);<br>-<br>-void PSPProgBar3Msr(void *Buffer)<br>-{<br>-   u32 Bar3Addr;<br>-        u64 Tmp64;<br>-   /* Get Bar3 Addr */<br>-  Bar3Addr = PspLibPciReadPspConfig(0x20);<br>-     Tmp64 = Bar3Addr;<br>-    printk(BIOS_DEBUG, "Bar3=%llx\n", Tmp64);<br>-  LibAmdMsrWrite(PSP_MSR_PRIVATE_BLOCK_BAR, &Tmp64, NULL);<br>- LibAmdMsrRead(PSP_MSR_PRIVATE_BLOCK_BAR, &Tmp64, NULL);<br>-}<br>-<br> static void model_15_init(device_t dev)<br> {<br>      printk(BIOS_DEBUG, "Model 15 Init.\n");<br>@@ -106,7 +89,6 @@<br>         }<br>     printk(BIOS_DEBUG, "siblings = %02d, ", siblings);<br> #endif<br>-        PSPProgBar3Msr(NULL);<br> <br>      /* DisableCf8ExtCfg */<br>        msr = rdmsr(NB_CFG_MSR);<br></pre><p>To view, visit <a href="https://review.coreboot.org/21492">change 21492</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21492"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7e77fad3abdcb6482f1b9d849e5922a426dff5f5 </div>
<div style="display:none"> Gerrit-Change-Number: 21492 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>