<p>Keith Hui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21474">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">winbond/w83627hf: Drop early_init.c<br><br>Once w83627hf_set_clksel_48() is unified into<br>winbond/common/early_init.c by /c/21331 (Unify w*_set_clksel_48()),<br>this file is no longer needed and can be dropped.<br><br>Build tested on select affected mainboards.<br><br>Change-Id: I6a5e27fdd48c6e002c3a39dc92fef77e85aea209<br>Signed-off-by: Keith Hui <buurin@gmail.com><br>---<br>M src/superio/winbond/w83627hf/Makefile.inc<br>D src/superio/winbond/w83627hf/early_init.c<br>M src/superio/winbond/w83627hf/w83627hf.h<br>3 files changed, 0 insertions(+), 56 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/21474/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/superio/winbond/w83627hf/Makefile.inc b/src/superio/winbond/w83627hf/Makefile.inc<br>index 93d011e..09b9368 100644<br>--- a/src/superio/winbond/w83627hf/Makefile.inc<br>+++ b/src/superio/winbond/w83627hf/Makefile.inc<br>@@ -16,5 +16,4 @@<br> ## GNU General Public License for more details.<br> ##<br> <br>-romstage-$(CONFIG_SUPERIO_WINBOND_W83627HF) += early_init.c<br> ramstage-$(CONFIG_SUPERIO_WINBOND_W83627HF) += superio.c<br>diff --git a/src/superio/winbond/w83627hf/early_init.c b/src/superio/winbond/w83627hf/early_init.c<br>deleted file mode 100644<br>index 1ec9810..0000000<br>--- a/src/superio/winbond/w83627hf/early_init.c<br>+++ /dev/null<br>@@ -1,51 +0,0 @@<br>-/*<br>- * This file is part of the coreboot project.<br>- *<br>- * Copyright (C) 2000 AG Electronics Ltd.<br>- * Copyright (C) 2003-2004 Linux Networx<br>- * Copyright (C) 2004 Tyan<br>- * Copyright (C) 2010 Win Enterprises (anishp@win-ent.com)<br>- *<br>- * This program is free software; you can redistribute it and/or modify<br>- * it under the terms of the GNU General Public License as published by<br>- * the Free Software Foundation; either version 2 of the License, or<br>- * (at your option) any later version.<br>- *<br>- * This program is distributed in the hope that it will be useful,<br>- * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>- * GNU General Public License for more details.<br>- */<br>-<br>-#include <arch/io.h><br>-#include <device/pnp.h><br>-#include "w83627hf.h"<br>-<br>-static void pnp_enter_ext_func_mode(pnp_devfn_t dev)<br>-{<br>- u16 port = dev >> 8;<br>- outb(0x87, port);<br>- outb(0x87, port);<br>-}<br>-<br>-static void pnp_exit_ext_func_mode(pnp_devfn_t dev)<br>-{<br>- u16 port = dev >> 8;<br>- outb(0xaa, port);<br>-}<br>-<br>-/*<br>- * We duplicate this function, for non-ROMCC boards, from early_serial.c to<br>- * work around a limitation of ROMCC where we can no make early_serial.c into<br>- * link-time symbols and #include early_serial.c.<br>- */<br>-void w83627hf_set_clksel_48(pnp_devfn_t dev)<br>-{<br>- u8 reg8;<br>-<br>- pnp_enter_ext_func_mode(dev);<br>- reg8 = pnp_read_config(dev, 0x24);<br>- reg8 |= (1 << 6); /* Set CLKSEL (clock input on pin 1) to 48MHz. */<br>- pnp_write_config(dev, 0x24, reg8);<br>- pnp_exit_ext_func_mode(dev);<br>-}<br>diff --git a/src/superio/winbond/w83627hf/w83627hf.h b/src/superio/winbond/w83627hf/w83627hf.h<br>index 4b55e0f..ecbf050 100644<br>--- a/src/superio/winbond/w83627hf/w83627hf.h<br>+++ b/src/superio/winbond/w83627hf/w83627hf.h<br>@@ -109,8 +109,4 @@<br> #define W83627HF_XSCNF 0x15<br> #define W83627HF_XWBCNF 0x16<br> <br>-#include <arch/io.h><br>-<br>-void w83627hf_set_clksel_48(pnp_devfn_t dev);<br>-<br> #endif /* SUPERIO_WINBOND_W83627HF_H */<br></pre><p>To view, visit <a href="https://review.coreboot.org/21474">change 21474</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21474"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6a5e27fdd48c6e002c3a39dc92fef77e85aea209 </div>
<div style="display:none"> Gerrit-Change-Number: 21474 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Hui <buurin@gmail.com> </div>