<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21472">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/i945/raminit.c: Clean sdram_program_dram_width()<br><br>Use macro instead of numbers<br><br>Change-Id: Ife1aff0a5cf311881b3a11533b71a74c518a633f<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/northbridge/intel/i945/raminit.c<br>1 file changed, 20 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/21472/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c<br>index 8fe589b..f10f108 100644<br>--- a/src/northbridge/intel/i945/raminit.c<br>+++ b/src/northbridge/intel/i945/raminit.c<br>@@ -880,29 +880,29 @@<br>              idx = 1;<br> <br>   switch (sysinfo->dimm[0]) {<br>-       case 0:<br>-              c0dramw = 0x0000; break; /* x16DS */<br>- case 1:<br>-              c0dramw = 0x0001; break; /* x8DS */<br>-  case 2:<br>-              c0dramw = 0x0000; break; /* x16SS */<br>- case 3:<br>-              c0dramw = 0x0005; break; /* x8DDS */<br>- case 4:<br>-              c0dramw = 0x0000; break; /* NC */<br>+    case SYSINFO_DIMM_X16DS:<br>+             c0dramw = 0x0000; break;<br>+     case SYSINFO_DIMM_X8DS:<br>+              c0dramw = 0x0001; break;<br>+     case SYSINFO_DIMM_X16SS:<br>+             c0dramw = 0x0000; break;<br>+     case SYSINFO_DIMM_X8DDS:<br>+             c0dramw = 0x0005; break;<br>+     case SYSINFO_DIMM_NOT_POPULATED:<br>+             c0dramw = 0x0000; break;<br>      }<br> <br>  switch (sysinfo->dimm[idx]) {<br>-     case 0:<br>-              c1dramw = 0x0000; break; /* x16DS */<br>- case 1:<br>-              c1dramw = 0x0010; break; /* x8DS */<br>-  case 2:<br>-              c1dramw = 0x0000; break; /* x16SS */<br>- case 3:<br>-              c1dramw = 0x0050; break; /* x8DDS */<br>- case 4:<br>-              c1dramw = 0x0000; break; /* NC */<br>+    case SYSINFO_DIMM_X16DS:<br>+             c1dramw = 0x0000; break;<br>+     case SYSINFO_DIMM_X8DS:<br>+              c1dramw = 0x0010; break;<br>+     case SYSINFO_DIMM_X16SS:<br>+             c1dramw = 0x0000; break;<br>+     case SYSINFO_DIMM_X8DDS:<br>+             c1dramw = 0x0050; break;<br>+     case SYSINFO_DIMM_NOT_POPULATED:<br>+             c1dramw = 0x0000; break;<br>      }<br> <br>  if (!sdram_capabilities_dual_channel()) {<br></pre><p>To view, visit <a href="https://review.coreboot.org/21472">change 21472</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21472"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ife1aff0a5cf311881b3a11533b71a74c518a633f </div>
<div style="display:none"> Gerrit-Change-Number: 21472 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>