<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21457">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">device/dram/ddr2: Fix decoding tRR<br><br>Bit 7 should not be used in computation.<br><br>Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/device/dram/ddr2.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/21457/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c<br>index 326b141..babfad7 100644<br>--- a/src/device/dram/ddr2.c<br>+++ b/src/device/dram/ddr2.c<br>@@ -179,8 +179,11 @@<br>  */<br> static u32 spd_decode_tRR_time(u8 c)<br> {<br>- switch (c) {<br>+ switch (c & ~0x80) {<br>      default:<br>+             printk(BIOS_DEBUG,<br>+                   "Unkown tRR value, using default of 15.6us.");<br>+             /* Fallthrough */<br>     case 0:<br>               return 15625 << 8;<br>      case 1:<br></pre><p>To view, visit <a href="https://review.coreboot.org/21457">change 21457</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21457"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 </div>
<div style="display:none"> Gerrit-Change-Number: 21457 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>