<p>Kevin Chiu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21400">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/snappy: Update EC keyboard backlight flag by SKU ID<br><br>Set SKU ID by ec command EC_CMD_SET_SKU_ID to update EC keyboard backlight<br>flag.<br><br>BUG=none<br>BRANCH=reef<br>TEST=emerge-snappy coreboot<br>Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292<br>Signed-off-by: Kevin Chiu <Kevin.Chiu@quantatw.com><br>---<br>M src/ec/google/chromeec/ec.c<br>M src/ec/google/chromeec/ec.h<br>M src/ec/google/chromeec/ec_commands.h<br>M src/mainboard/google/reef/mainboard.c<br>4 files changed, 36 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/21400/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c<br>index 4d47982..c382849 100644<br>--- a/src/ec/google/chromeec/ec.c<br>+++ b/src/ec/google/chromeec/ec.c<br>@@ -263,6 +263,29 @@<br>      return r.flags[feature / 32] & EC_FEATURE_MASK_0(feature);<br> }<br> <br>+int google_chromeec_set_sku_id(int skuid)<br>+{<br>+        struct chromeec_command cmd;<br>+ struct ec_params_set_sku_id set_skuid = {<br>+            .sku_id = skuid<br>+      };<br>+<br>+        printk(BIOS_DEBUG, "DBG: google_chromeec_set_sku_id: %d\n", skuid);<br>+<br>+     cmd.cmd_code = EC_CMD_GET_SKU_ID;<br>+    cmd.cmd_version = 0;<br>+ cmd.cmd_size_in = sizeof(set_skuid);<br>+ cmd.cmd_data_in = &set_skuid;<br>+    cmd.cmd_data_out = NULL;<br>+     cmd.cmd_size_out = 0;<br>+        cmd.cmd_dev_index = 0;<br>+<br>+    if (google_chromeec_command(&cmd) != 0)<br>+          return -1;<br>+<br>+        return 0;<br>+}<br>+<br> #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_RTC)<br> int rtc_get(struct rtc_time *time)<br> {<br>diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h<br>index 60d5a32..59dae89 100644<br>--- a/src/ec/google/chromeec/ec.h<br>+++ b/src/ec/google/chromeec/ec.h<br>@@ -47,6 +47,7 @@<br> void google_chromeec_check_pd_image(int expected_type);<br> <br> int google_chromeec_check_feature(int feature);<br>+int google_chromeec_set_sku_id(int skuid);<br> uint8_t google_chromeec_calc_checksum(const uint8_t *data, int size);<br> u16 google_chromeec_get_board_version(void);<br> u32 google_chromeec_get_sku_id(void);<br>diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h<br>index 46ab905..6ce5db5 100644<br>--- a/src/ec/google/chromeec/ec_commands.h<br>+++ b/src/ec/google/chromeec/ec_commands.h<br>@@ -1129,6 +1129,13 @@<br> };<br> <br> /*****************************************************************************/<br>+/* set sku id */<br>+#define EC_CMD_GET_SKU_ID  0x0F<br>+struct ec_params_set_sku_id {<br>+        uint32_t sku_id;<br>+} __packed;<br>+<br>+/*****************************************************************************/<br> /* Flash commands */<br> <br> /* Get flash info */<br>diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c<br>index c6b1997..a2d3f81 100644<br>--- a/src/mainboard/google/reef/mainboard.c<br>+++ b/src/mainboard/google/reef/mainboard.c<br>@@ -28,6 +28,9 @@<br> #include <vendorcode/google/chromeos/chromeos.h><br> #include <variant/ec.h><br> #include <variant/gpio.h><br>+#include <ec/google/chromeec/ec.h><br>+<br>+static int board_sku(void);<br> <br> static void mainboard_init(void *chip_info)<br> {<br>@@ -38,6 +41,8 @@<br>    boardid = board_id();<br>         printk(BIOS_INFO, "Board ID: %d\n", boardid);<br> <br>+   google_chromeec_set_sku_id(board_sku());<br>+<br>   pads = variant_gpio_table(&num);<br>  gpio_configure_pads(pads, num);<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/21400">change 21400</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21400"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 </div>
<div style="display:none"> Gerrit-Change-Number: 21400 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Chiu <Kevin.Chiu@quantatw.com> </div>