<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21404">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/{cannonlake,skylake}: Fix klocwork issue<br><br>This patch fixes klocwork bug due to recent memmap.c<br>implementation.<br><br>Change-Id: I4c74ca410d1a0ba48634ec9928a0d9d1cc20e27a<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/cannonlake/memmap.c<br>M src/soc/intel/skylake/memmap.c<br>2 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/21404/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/cannonlake/memmap.c b/src/soc/intel/cannonlake/memmap.c<br>index 8f842c0..29f25f2 100644<br>--- a/src/soc/intel/cannonlake/memmap.c<br>+++ b/src/soc/intel/cannonlake/memmap.c<br>@@ -91,6 +91,8 @@<br>     size_t imr_size;<br> <br>   dev = dev_find_slot(0, PCI_DEVFN(SA_DEV_SLOT_IGD, 0));<br>+       if (!dev)<br>+            die("ERROR - device not found!");<br> <br>        /* Read TOLUD from Host Bridge offset */<br>      dram_base = sa_get_tolud_base();<br>diff --git a/src/soc/intel/skylake/memmap.c b/src/soc/intel/skylake/memmap.c<br>index 229afa7..6c64073 100644<br>--- a/src/soc/intel/skylake/memmap.c<br>+++ b/src/soc/intel/skylake/memmap.c<br>@@ -142,6 +142,8 @@<br>        size_t prmrr_size;<br> <br>         dev = dev_find_slot(0, PCI_DEVFN(SA_DEV_SLOT_IGD, 0));<br>+       if (!dev)<br>+            die("ERROR - device not found!");<br> <br>        /* Read TOLUD from Host Bridge offset */<br>      dram_base = sa_get_tolud_base();<br>@@ -160,7 +162,6 @@<br>         if (IS_ENABLED(CONFIG_SA_ENABLE_DPR))<br>                 dram_base -= sa_get_dpr_size();<br> <br>-   dev = dev_find_slot(0, PCI_DEVFN(SA_DEV_SLOT_ROOT, 0));<br>       config = dev->chip_info;<br>   if (IS_ENABLED(CONFIG_PLATFORM_USES_FSP1_1))<br>          prmrr_size = 1*MiB;<br></pre><p>To view, visit <a href="https://review.coreboot.org/21404">change 21404</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21404"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4c74ca410d1a0ba48634ec9928a0d9d1cc20e27a </div>
<div style="display:none"> Gerrit-Change-Number: 21404 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>