<p>Nico Huber <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/21323">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Arthur Heymans: Looks good to me, approved
  Nico Huber: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma: Add procedure to power up legacy VGA block<br><br>Calling this is necessary for VGA text mode on at least Skylake, where<br>the legacy VGA registers are inaccessible otherwise.<br><br>Change-Id: I48ba1738bcc7babd4e666e5266f775dcd06b2a3f<br>Signed-off-by: Nico Huber <nico.huber@secunet.com><br>Reviewed-on: https://review.coreboot.org/21323<br>Reviewed-by: Arthur Heymans <arthur@aheymans.xyz><br>Tested-by: Nico Huber <nico.h@gmx.de><br>---<br>M common/hw-gfx-gma.adb<br>M common/hw-gfx-gma.ads<br>2 files changed, 23 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb<br>index 99a1276..6bc6fea 100644<br>--- a/common/hw-gfx-gma.adb<br>+++ b/common/hw-gfx-gma.adb<br>@@ -438,6 +438,23 @@<br> <br>    ----------------------------------------------------------------------------<br> <br>+   procedure Power_Up_VGA<br>+   is<br>+      Fake_Config : constant Pipe_Configs :=<br>+        (Primary =><br>+           (Port        => Analog,<br>+            Framebuffer => HW.GFX.Default_FB,<br>+            Mode        => HW.GFX.Invalid_Mode),<br>+         others =><br>+           (Port        => Disabled,<br>+            Framebuffer => HW.GFX.Default_FB,<br>+            Mode        => HW.GFX.Invalid_Mode));<br>+   begin<br>+      Power_And_Clocks.Power_Up (Cur_Configs, Fake_Config);<br>+   end Power_Up_VGA;<br>+<br>+   ----------------------------------------------------------------------------<br>+<br>    function FB_First_Page (FB : Framebuffer_Type) return Natural is<br>      (Natural (FB.Offset / GTT_Page_Size));<br>    function FB_Pages (FB : Framebuffer_Type) return Natural is<br>diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads<br>index 3771804..cd992b8 100644<br>--- a/common/hw-gfx-gma.ads<br>+++ b/common/hw-gfx-gma.ads<br>@@ -80,6 +80,12 @@<br>       Global => (Input => Init_State);<br>    pragma Warnings (GNATprove, On, "unused variable ""Write_Delay""");<br> <br>+   pragma Warnings (GNATprove, Off, "subprogram ""Power_Up_VGA"" has no effect",<br>+                    Reason => "Effect depends on the platform compiled for");<br>+   procedure Power_Up_VGA<br>+   with<br>+      Pre => Is_Initialized;<br>+<br>    procedure Update_Outputs (Configs : Pipe_Configs);<br> <br>    pragma Warnings (GNATprove, Off, "subprogram ""Dump_Configs"" has no effect",<br></pre><p>To view, visit <a href="https://review.coreboot.org/21323">change 21323</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21323"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I48ba1738bcc7babd4e666e5266f775dcd06b2a3f </div>
<div style="display:none"> Gerrit-Change-Number: 21323 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>