<p>Damien Zammit has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21353">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fsp1_0/fsp_util: Rename find_fsp to find_fsp_dummy<br><br>To avoid error with symbol redefinition (using clang):<br>src/drivers/intel/fsp1_0/fsp_util.c:111:22: error: invalid symbol redefinition<br>                ".global find_fsp\n\t"<br>Rename the C function to find_fsp_dummy.<br><br>Change-Id: I84c152f9a580fdfc40e9f6e998d2d6484b7f47df<br>Signed-off-by: Damien Zammit <damien@zamaudio.com><br>---<br>M src/drivers/intel/fsp1_0/fsp_util.c<br>M src/drivers/intel/fsp1_0/fsp_util.h<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/21353/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/intel/fsp1_0/fsp_util.c b/src/drivers/intel/fsp1_0/fsp_util.c<br>index fc1bd51..b10aa45 100644<br>--- a/src/drivers/intel/fsp1_0/fsp_util.c<br>+++ b/src/drivers/intel/fsp1_0/fsp_util.c<br>@@ -35,7 +35,7 @@<br>    EFI_STATUS             Status;<br> <br>     if (fsp_header_ptr == NULL) {<br>-                fsp_header_ptr = (void *)find_fsp();<br>+         fsp_header_ptr = (void *)find_fsp_dummy();<br>            if ((u32)fsp_header_ptr < 0xff) {<br>                  post_code(0x4F); /* output something in case there is no serial */<br>                    die("Can't find the FSP!\n");<br>@@ -100,7 +100,7 @@<br> }<br> #endif   /* __PRE_RAM__ */<br> <br>-volatile u8 * find_fsp ()<br>+volatile u8 * find_fsp_dummy ()<br> {<br> <br> #ifdef __PRE_RAM__<br>@@ -213,7 +213,7 @@<br> void print_fsp_info(void) {<br> <br>  if (fsp_header_ptr == NULL)<br>-          fsp_header_ptr = (void *)find_fsp();<br>+         fsp_header_ptr = (void *)find_fsp_dummy();<br> <br>         if ((u32)fsp_header_ptr < 0xff) {<br>          post_code(0x4F); /* post code in case there is no serial */<br>diff --git a/src/drivers/intel/fsp1_0/fsp_util.h b/src/drivers/intel/fsp1_0/fsp_util.h<br>index badd254..7eb37ac 100644<br>--- a/src/drivers/intel/fsp1_0/fsp_util.h<br>+++ b/src/drivers/intel/fsp1_0/fsp_util.h<br>@@ -25,7 +25,7 @@<br> void * find_and_set_fastboot_cache(void);<br> #endif<br> <br>-volatile u8 * find_fsp (void);<br>+volatile u8 * find_fsp_dummy (void);<br> void fsp_early_init(FSP_INFO_HEADER *fsp_info);<br> void FspNotify(u32 Phase);<br> void FspNotifyReturnPoint(EFI_STATUS Status, VOID *HobListPtr);<br></pre><p>To view, visit <a href="https://review.coreboot.org/21353">change 21353</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21353"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I84c152f9a580fdfc40e9f6e998d2d6484b7f47df </div>
<div style="display:none"> Gerrit-Change-Number: 21353 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Damien Zammit <damien@zamaudio.com> </div>