<p>Iru Cai has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21310">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/hp: Enable ExpressCard hotplug in all Elitebooks<br><br>The MPC.HPCE bit of the ExpressCard root port is not set in vendor<br>firmware, so autoport didn't generate the right pcie_hotplug_map to<br>support ExpressCard hotplug.<br><br>Also add comments for each PCIe root port.<br><br>Change-Id: Ic53e36a7192b9bfa8ff9fca57f4556e972e2611b<br>Signed-off-by: Iru Cai <mytbk920423@gmail.com><br>---<br>M src/mainboard/hp/2570p/devicetree.cb<br>M src/mainboard/hp/2760p/devicetree.cb<br>M src/mainboard/hp/8460p/devicetree.cb<br>M src/mainboard/hp/8470p/devicetree.cb<br>4 files changed, 16 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/21310/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/hp/2570p/devicetree.cb b/src/mainboard/hp/2570p/devicetree.cb<br>index 6dcfb61..753d286 100644<br>--- a/src/mainboard/hp/2570p/devicetree.cb<br>+++ b/src/mainboard/hp/2570p/devicetree.cb<br>@@ -56,7 +56,7 @@<br> register "gen4_dec" = "0x000402e9"<br> register "gpi6_routing" = "2"<br> register "p_cnt_throttling_supported" = "1"<br>- register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }"<br>+ register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }"<br> register "pcie_port_coalesce" = "1"<br> register "sata_interface_speed_support" = "0x3"<br> register "sata_port_map" = "0x33"<br>@@ -89,13 +89,13 @@<br> device pci 1c.0 on # PCIe Port #1<br> subsystemid 0x103c 0x17df<br> end<br>- device pci 1c.1 on # PCIe Port #2<br>+ device pci 1c.1 on # PCIe Port #2, ExpressCard<br> subsystemid 0x103c 0x17df<br> end<br>- device pci 1c.2 on # PCIe Port #3<br>+ device pci 1c.2 on # PCIe Port #3, SD/MMC<br> subsystemid 0x103c 0x17df<br> end<br>- device pci 1c.3 on # PCIe Port #4<br>+ device pci 1c.3 on # PCIe Port #4, WLAN<br> subsystemid 0x103c 0x17df<br> end<br> device pci 1c.4 off # PCIe Port #5<br>diff --git a/src/mainboard/hp/2760p/devicetree.cb b/src/mainboard/hp/2760p/devicetree.cb<br>index 5728ad9..e63b69c 100644<br>--- a/src/mainboard/hp/2760p/devicetree.cb<br>+++ b/src/mainboard/hp/2760p/devicetree.cb<br>@@ -65,7 +65,7 @@<br> register "gen4_dec" = "0x007c0281"<br> register "gpi6_routing" = "2"<br> register "p_cnt_throttling_supported" = "1"<br>- register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }"<br>+ register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }"<br> register "pcie_port_coalesce" = "1"<br> register "sata_interface_speed_support" = "0x3"<br> register "sata_port_map" = "0x21"<br>@@ -94,10 +94,10 @@<br> device pci 1c.0 on # PCIe Port #1<br> subsystemid 0x103c 0x162a<br> end<br>- device pci 1c.1 on # PCIe Port #2<br>+ device pci 1c.1 on # PCIe Port #2, ExpressCard<br> subsystemid 0x103c 0x162a<br> end<br>- device pci 1c.2 on # PCIe Port #3<br>+ device pci 1c.2 on # PCIe Port #3, SD/MMC<br> subsystemid 0x103c 0x162a<br> end<br> device pci 1c.3 on # WLAN<br>diff --git a/src/mainboard/hp/8460p/devicetree.cb b/src/mainboard/hp/8460p/devicetree.cb<br>index 4b1df4a..866f57e 100644<br>--- a/src/mainboard/hp/8460p/devicetree.cb<br>+++ b/src/mainboard/hp/8460p/devicetree.cb<br>@@ -64,7 +64,7 @@<br> register "gen4_dec" = "0x000402e9"<br> register "gpi6_routing" = "2"<br> register "p_cnt_throttling_supported" = "1"<br>- register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }"<br>+ register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }"<br> register "pcie_port_coalesce" = "1"<br> register "sata_interface_speed_support" = "0x3"<br> register "sata_port_map" = "0x3b"<br>@@ -94,13 +94,13 @@<br> device pci 1c.0 on # PCIe Port #1<br> subsystemid 0x103c 0x161c<br> end<br>- device pci 1c.1 on # PCIe Port #2<br>+ device pci 1c.1 on # PCIe Port #2, ExpressCard<br> subsystemid 0x103c 0x161c<br> end<br>- device pci 1c.2 on # PCIe Port #3<br>+ device pci 1c.2 on # PCIe Port #3, SD/MMC<br> subsystemid 0x103c 0x161c<br> end<br>- device pci 1c.3 on # PCIe Port #4<br>+ device pci 1c.3 on # PCIe Port #4, WLAN<br> subsystemid 0x103c 0x161c<br> end<br> device pci 1c.4 off # PCIe Port #5<br>@@ -109,7 +109,7 @@<br> end<br> device pci 1c.6 off # PCIe Port #7<br> end<br>- device pci 1c.7 on # PCIe Port #8<br>+ device pci 1c.7 on # PCIe Port #8, NEC USB 3.0 Host Controller<br> subsystemid 0x103c 0x161c<br> end<br> device pci 1d.0 on # USB2 EHCI #1<br>diff --git a/src/mainboard/hp/8470p/devicetree.cb b/src/mainboard/hp/8470p/devicetree.cb<br>index 6baccca..b7254bb 100644<br>--- a/src/mainboard/hp/8470p/devicetree.cb<br>+++ b/src/mainboard/hp/8470p/devicetree.cb<br>@@ -65,7 +65,7 @@<br> register "gen4_dec" = "0x000402e9"<br> register "gpi6_routing" = "2"<br> register "p_cnt_throttling_supported" = "1"<br>- register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }"<br>+ register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }"<br> register "pcie_port_coalesce" = "1"<br> register "sata_interface_speed_support" = "0x3"<br> register "sata_port_map" = "0x3b"<br>@@ -101,13 +101,13 @@<br> device pci 1c.0 on # PCIe Port #1<br> subsystemid 0x103c 0x179b<br> end<br>- device pci 1c.1 on # PCIe Port #2<br>+ device pci 1c.1 on # PCIe Port #2, ExpressCard<br> subsystemid 0x103c 0x179b<br> end<br>- device pci 1c.2 on # PCIe Port #3<br>+ device pci 1c.2 on # PCIe Port #3, SD/MMC<br> subsystemid 0x103c 0x179b<br> end<br>- device pci 1c.3 on # PCIe Port #4<br>+ device pci 1c.3 on # PCIe Port #4, WLAN<br> subsystemid 0x103c 0x179b<br> end<br> device pci 1c.4 off # PCIe Port #5<br></pre><p>To view, visit <a href="https://review.coreboot.org/21310">change 21310</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21310"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic53e36a7192b9bfa8ff9fca57f4556e972e2611b </div>
<div style="display:none"> Gerrit-Change-Number: 21310 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> </div>