<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21330">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/lulu,gandof: set kb backlight on boot<br><br>Set keyboard backlight to 75% on boot, except when resuming<br>from S3.  This enables the backlight at a reasonable level<br>prior to the OS driver taking over, providing early proof-of-life<br>and enhanced usability in grub etc.<br><br>Uses same method as other google boards with a keyboard backlight<br>(chell, link, samus).  75% value determined based on user feedback.<br><br>TEST: boot google/lulu,gandof boards, observe keyboard backlight<br>enabled in pre-OS environment.<br><br>Change-Id: I7ed59289419af21764b1b5bd0a534d3b630c6c6b<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/auron/variants/gandof/variant.c<br>M src/mainboard/google/auron/variants/lulu/variant.c<br>2 files changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/21330/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/auron/variants/gandof/variant.c b/src/mainboard/google/auron/variants/gandof/variant.c<br>index f1af14d..ad88f0d 100644<br>--- a/src/mainboard/google/auron/variants/gandof/variant.c<br>+++ b/src/mainboard/google/auron/variants/gandof/variant.c<br>@@ -11,6 +11,8 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>+#include <ec/google/chromeec/ec.h><br>+#include <soc/pm.h><br> #include <smbios.h><br> #include <soc/romstage.h><br> #include <variant/onboard.h><br>@@ -35,5 +37,6 @@<br> <br> void variant_romstage_entry(struct romstage_params *rp)<br> {<br>-  /* N/A for boards other than SAMUS */<br>+        if (rp->power_state->prev_sleep_state != ACPI_S3)<br>+              google_chromeec_kbbacklight(75);<br> }<br>diff --git a/src/mainboard/google/auron/variants/lulu/variant.c b/src/mainboard/google/auron/variants/lulu/variant.c<br>index 740decf..9d77c27 100644<br>--- a/src/mainboard/google/auron/variants/lulu/variant.c<br>+++ b/src/mainboard/google/auron/variants/lulu/variant.c<br>@@ -11,6 +11,8 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>+#include <ec/google/chromeec/ec.h><br>+#include <soc/pm.h><br> #include <smbios.h><br> #include <soc/romstage.h><br> #include <variant/onboard.h><br>@@ -44,5 +46,6 @@<br> <br> void variant_romstage_entry(struct romstage_params *rp)<br> {<br>-    /* N/A for boards other than SAMUS */<br>+        if (rp->power_state->prev_sleep_state != ACPI_S3)<br>+              google_chromeec_kbbacklight(75);<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/21330">change 21330</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21330"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7ed59289419af21764b1b5bd0a534d3b630c6c6b </div>
<div style="display:none"> Gerrit-Change-Number: 21330 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>