<p>Timothy Pearson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21217">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/sb/sb700: Allocate wide LPC I/O devices where possible<br><br>When more than 2 wide I/O LPC devices were requested, none of<br>the devices were actually allocated.  Furthermore, even though<br>more than three wide I/O devices are not permitted, it is better<br>to allocate the first three than to allocate none.<br><br>Always allocate the first three wide I/O devices from the wide<br>I/O request list.<br><br>Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297<br>Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com><br>---<br>M src/southbridge/amd/sb700/lpc.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/21217/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/southbridge/amd/sb700/lpc.c b/src/southbridge/amd/sb700/lpc.c<br>index 8ee0395..98d6256 100644<br>--- a/src/southbridge/amd/sb700/lpc.c<br>+++ b/src/southbridge/amd/sb700/lpc.c<br>@@ -217,8 +217,11 @@<br>                                                reg_x |= (1 << 23);<br>                                             break;<br>                                        default:<br>-                                             if (var_num >= 3)<br>+                                         if (var_num >= 3) {<br>+                                                       printk(BIOS_WARNING, "%s: Ignoring resource %s [base=0x%08x, end=0x%08x] due to"<br>+                                                                           "I/O window exhaustion\n", __func__, dev_path(child), base, end);<br>                                                   continue;       /* only 3 var ; compact them ? */<br>+                                            }<br>                                             switch (var_num) {<br>                                            case 0:<br>                                                       reg_x |= (1 << 2);<br>@@ -232,7 +235,6 @@<br>                                                         break;<br>                                                case 2:<br>                                                       reg_x |= (1 << 25);<br>-                                                    reg_x |= (1 << 24);<br>                                                     if ((end - base) < 16)<br>                                                             wiosize |= (1 << 3);<br>                                                    break;<br>@@ -248,6 +250,7 @@<br>   pci_write_config32(dev, 0x48, reg_x);<br>         /* Set WideIO for as many IOs found (fall through is on purpose) */<br>   switch (var_num) {<br>+   default:<br>      case 2:<br>               pci_write_config16(dev, 0x90, reg_var[2]);<br>    case 1:<br></pre><p>To view, visit <a href="https://review.coreboot.org/21217">change 21217</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21217"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I004bd0be31c91b76ae2a5e72690b44dca2fd9297 </div>
<div style="display:none"> Gerrit-Change-Number: 21217 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Timothy Pearson <tpearson@raptorengineering.com> </div>