<p>Nico Huber <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21178">View Change</a></p><p>Patch set 7:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks good now. Alas, I spotted a semantical problem.</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21178/7/src/southbridge/intel/bd82x6x/pch.c">File src/southbridge/intel/bd82x6x/pch.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21178/7/src/southbridge/intel/bd82x6x/pch.c@294">Patch Set #7, Line 294:</a> <code style="font-family:monospace,monospace">                                [PCI_FUNC(dev->path.pci.devfn)];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be done before the `if`. Slots that didn't move<br>need the hotplug setting copied too. Alternatively you could<br>initialize `new_hotplug_map` with the values of the old map.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21178">change 21178</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21178"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad </div>
<div style="display:none"> Gerrit-Change-Number: 21178 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 26 Aug 2017 11:44:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>