<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21171">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/cyan: Add 2nd source memory 2-channel 4G (Micro/Samsung)<br><br>Cherry-pick from Chromium commit 7f0cdf0.<br><br>Cyan board add 4G DDR3L 2nd source memory (Micro/Samsung)<br><br>Original-Change-Id: I12f82082d8227e61a97ce0a001d7d2b1f6613e06<br>Original-Signed-off-by: T.H. Lin <T.H_Lin@quantatw.com><br>Original-Reviewed-by: Shawn N <shawnn@chromium.org><br><br>Change-Id: Ieca7201346414d7a962f9619dbe846c67c0f02d6<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/cyan/spd/Makefile.inc<br>M src/mainboard/google/cyan/spd/spd.c<br>2 files changed, 12 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/21171/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/cyan/spd/Makefile.inc b/src/mainboard/google/cyan/spd/Makefile.inc<br>index 543ac73..f596086 100644<br>--- a/src/mainboard/google/cyan/spd/Makefile.inc<br>+++ b/src/mainboard/google/cyan/spd/Makefile.inc<br>@@ -22,8 +22,8 @@<br> SPD_SOURCES += hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR<br> SPD_SOURCES += samsung_2GiB_dimm_K4B4G1646Q-HYK0<br> SPD_SOURCES += hynix_2GiB_dimm_HMT425S6CFR6A_H5TC4G63CFR<br>-SPD_SOURCES += empty<br>-SPD_SOURCES += empty<br>+SPD_SOURCES += samsung_2GiB_dimm_K4B4G1646E-BYK0<br>+SPD_SOURCES += micron_2GiB_dimm_MT41K256M16TW-107<br> SPD_SOURCES += samsung_2GiB_dimm_K4B4G1646E-BYK0<br> SPD_SOURCES += micron_2GiB_dimm_MT41K256M16TW-107<br> <br>diff --git a/src/mainboard/google/cyan/spd/spd.c b/src/mainboard/google/cyan/spd/spd.c<br>index 5b7dc73..cbe8ceb 100644<br>--- a/src/mainboard/google/cyan/spd/spd.c<br>+++ b/src/mainboard/google/cyan/spd/spd.c<br>@@ -33,10 +33,13 @@<br>  * 0b0001 - 4GiB total - 2 x 2GiB Hynix  H5TC4G63CFR-PBA 1600MHz<br>  * 0b0010 - 2GiB total - 1 x 2GiB Samsung K4B4G1646Q-HYK0 1600MHz<br>  * 0b0011 - 2GiB total - 1 x 2GiB Hynix  H5TC4G63CFR-PBA 1600MHz<br>+ * 0b0100 - 4GiB total - 2 x 2GiB Samsung K4B4G1646E-BYK0 1600MHz<br>+ * 0b0101 - 4GiB total - 2 x 2GiB Micro MT41K256M16TW-107 1600MHz<br>  * 0b0110 - 2GiB total - 1 x 2GiB Samsung K4B4G1646E-BYK0 1600MHz<br>  * 0b0111 - 2GiB total - 1 x 2GiB Micro MT41K256M16TW-107 1600MHz<br>  */<br>-static const uint32_t dual_channel_config = (1 << 0) | (1 << 1);<br>+static const uint32_t dual_channel_config = (1 << 0) | (1 << 1)<br>+                     | (1 << 4) | (1 << 5);<br> <br> static void *get_spd_pointer(char *spd_file_content, int total_spds, int *dual)<br> {<br>@@ -72,6 +75,12 @@<br>       case 3:<br>               printk(BIOS_DEBUG, "2GiB Hynix  H5TC4G63CFR-PBA 1600MHz\n");<br>                break;<br>+       case 4:<br>+              printk(BIOS_DEBUG, "4GiB Samsung K4B4G1646E-BYK0 1600MHz\n");<br>+              break;<br>+       case 5:<br>+              printk(BIOS_DEBUG, "4GiB Micro MT41K256M16TW-107 1600MHz\n");<br>+              break;<br>        case 6:<br>               printk(BIOS_DEBUG, "2GiB Samsung K4B4G1646E-BYK0 1600MHz\n");<br>               break;<br></pre><p>To view, visit <a href="https://review.coreboot.org/21171">change 21171</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21171"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ieca7201346414d7a962f9619dbe846c67c0f02d6 </div>
<div style="display:none"> Gerrit-Change-Number: 21171 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: T.H. Lin <T.H_Lin@quantatw.com> </div>