<p>Paul Menzel <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20741">View Change</a></p><p>Patch set 8:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20741/8//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20741/8//COMMIT_MSG@9">Patch Set #8, Line 9:</a> <code style="font-family:monospace,monospace">PMIC(tps68470)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please add a space before the `(`.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mipi_camera.asl">File src/mainboard/google/poppy/acpi/mipi_camera.asl:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mipi_camera.asl@32">Patch Set #8, Line 32:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                        * Turn on 3V3_VDD. It takes around 1 ms<br>                       * for volatge to settle to 3.3 Volt.<br>                  * Provide additional 2 ms before we<br>                   * enable regulators.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The allowed text width is longer.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mipi_camera.asl@59">Patch Set #8, Line 59:</a> <code style="font-family:monospace,monospace">                     * This reset is avoided in S3 & S0ix resume.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do not reset PMIC in S3 & S0ix resume.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20741">change 20741</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20741"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 </div>
<div style="display:none"> Gerrit-Change-Number: 20741 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Ricky Liang <jcliang@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Tomasz Figa <tfiga@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 22 Aug 2017 10:09:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>