<p>Nico Huber <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/20601">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Nico Huber: Verified
  Arthur Heymans: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma: Clear "fence" registers during initialization<br><br>These registers are used to mark certain GTT regions as tiled.<br><br>Change-Id: Ic2cd61c0c1b42990ed955d7f77a428a2b9dbabd5<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>Reviewed-on: https://review.coreboot.org/20601<br>Reviewed-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M common/hw-gfx-gma-registers.adb<br>M common/hw-gfx-gma-registers.ads<br>M common/hw-gfx-gma.adb<br>3 files changed, 18 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/common/hw-gfx-gma-registers.adb b/common/hw-gfx-gma-registers.adb<br>index 9e52c78..4a22564 100644<br>--- a/common/hw-gfx-gma-registers.adb<br>+++ b/common/hw-gfx-gma-registers.adb<br>@@ -61,6 +61,21 @@<br> <br>    ----------------------------------------------------------------------------<br> <br>+   procedure Clear_Fences<br>+   is<br>+      Fence_Regs_Base : constant :=<br>+        (case Config.CPU is<br>+            when Ironlake                 => 16#00_3000#,<br>+            when Sandybridge .. Skylake   => 16#10_0000#);<br>+      subtype Fence_Range is Registers_Range range 0 .. 63;<br>+   begin<br>+      for Idx in Fence_Range loop<br>+         Regs.Write (Fence_Regs_Base / Register_Width + Idx, 0);<br>+      end loop;<br>+   end Clear_Fences;<br>+<br>+   ----------------------------------------------------------------------------<br>+<br>    procedure Write_GTT<br>      (GTT_Page       : GTT_Range;<br>       Device_Address : GTT_Address_Type;<br>diff --git a/common/hw-gfx-gma-registers.ads b/common/hw-gfx-gma-registers.ads<br>index 63df8be..2a01aab 100644<br>--- a/common/hw-gfx-gma-registers.ads<br>+++ b/common/hw-gfx-gma-registers.ads<br>@@ -1529,6 +1529,8 @@<br>        Mask_Unset : Word32;<br>        Mask_Set   : Word32);<br> <br>+   procedure Clear_Fences;<br>+<br>    pragma Warnings (Off, "declaration of ""Write_GTT"" hides one at *");<br>    procedure Write_GTT<br>      (GTT_Page       : GTT_Range;<br>diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb<br>index 387d6bd..94f3ceb 100644<br>--- a/common/hw-gfx-gma.adb<br>+++ b/common/hw-gfx-gma.adb<br>@@ -401,6 +401,7 @@<br>          Connectors.Post_All_Off;<br>          PLLs.All_Off;<br>          Power_And_Clocks.Post_All_Off;<br>+         Registers.Clear_Fences;<br>       else<br>          -- According to PRMs, VGA plane is the only thing<br>          -- that's enabled by default after reset.<br></pre><p>To view, visit <a href="https://review.coreboot.org/20601">change 20601</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20601"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic2cd61c0c1b42990ed955d7f77a428a2b9dbabd5 </div>
<div style="display:none"> Gerrit-Change-Number: 20601 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>