<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21122">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/cyan: Fix Touchscreen Interrupt<br><br>Cherry-pick from Chromium commit 1138727.<br><br>Elan touchscreen driver expects the first gpio resource in asl<br>to be the reset line.<br>The driver considers the gpio based irq line as reset gpio resource<br>and changes the direction to output.<br>This will cause irq registration to fail.<br><br>Solution is to pass Interrupt resource for touchscreen irq<br>instead of GpioInt.<br><br>Original-Change-Id: Ia72d4ad80117f3c0014098113c9027416026e65e<br>Original-Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@intel.com><br>Original-Reviewed-by: Duncan Laurie <dlaurie@chromium.org><br><br>Change-Id: I1c4b029851e321feeedf713186976fbec42dd82e<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/cyan/acpi/mainboard.asl<br>M src/mainboard/google/cyan/onboard.h<br>2 files changed, 10 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/21122/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/cyan/acpi/mainboard.asl b/src/mainboard/google/cyan/acpi/mainboard.asl<br>index 31b9090..9d68065 100644<br>--- a/src/mainboard/google/cyan/acpi/mainboard.asl<br>+++ b/src/mainboard/google/cyan/acpi/mainboard.asl<br>@@ -46,8 +46,10 @@<br>                                   AddressingMode7Bit,       /* AddressingMode */<br>                                        "\\_SB.PCI0.I2C1",        /* ResourceSource */<br>                              )<br>-                            GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,<br>-                                        "\\_SB.GPSW") { BOARD_TOUCH_GPIO_INDEX }<br>+                          Interrupt (ResourceConsumer, Edge, ActiveLow)<br>+                                {<br>+                                    BOARD_PRE_EVT_TOUCH_IRQ<br>+                              }<br> <br>                  } )<br>                   Name(BUF1,ResourceTemplate ()<br>@@ -59,8 +61,10 @@<br>                                     AddressingMode7Bit,       /* AddressingMode */<br>                                        "\\_SB.PCI0.I2C1",        /* ResourceSource */<br>                              )<br>-                            GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,<br>-                                        "\\_SB.GPNC") { BOARD_EVT_TOUCH_GPIO_INDEX }<br>+                              Interrupt (ResourceConsumer, Edge, ActiveLow)<br>+                                {<br>+                                    BOARD_TOUCH_IRQ<br>+                              }<br> <br>                  } )<br>                   If (LEqual (\BDID, BOARD_EVT)) {<br>diff --git a/src/mainboard/google/cyan/onboard.h b/src/mainboard/google/cyan/onboard.h<br>index f03f1df..1347d41 100644<br>--- a/src/mainboard/google/cyan/onboard.h<br>+++ b/src/mainboard/google/cyan/onboard.h<br>@@ -36,6 +36,8 @@<br>  */<br> /* ToDO: change kbd irq to gpio bank index */<br> #define BOARD_I8042_IRQ                        182<br>+#define BOARD_TOUCH_IRQ                   184<br>+#define BOARD_PRE_EVT_TOUCH_IRQ           156<br> <br> <br> /* SCI: Gpio index in N bank */<br></pre><p>To view, visit <a href="https://review.coreboot.org/21122">change 21122</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21122"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1c4b029851e321feeedf713186976fbec42dd82e </div>
<div style="display:none"> Gerrit-Change-Number: 21122 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@intel.com> </div>