<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21031">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Remove TCO lock down programming<br><br>FSP is doing TCO lock inside Notofy 1 hence remove<br>TCO Lock down programming inside coreboot.<br><br>TEST= Ensure TCO_LOCK offset 8 bit 12 is set.<br><br>Change-Id: Iec9e3075df01862f8558b303a458126c68202bff<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/skylake/finalize.c<br>1 file changed, 0 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/21031/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c<br>index 53c1c58..aed7e87 100644<br>--- a/src/soc/intel/skylake/finalize.c<br>+++ b/src/soc/intel/skylake/finalize.c<br>@@ -86,8 +86,6 @@<br> {<br>     device_t dev;<br>         uint32_t reg32;<br>-      u16 tcobase;<br>- u16 tcocnt;<br>   uint8_t *pmcbase;<br>     config_t *config;<br>     u8 reg8;<br>@@ -97,12 +95,6 @@<br> <br>       /* Lock FAST_SPIBAR */<br>        fast_spi_lock_bar();<br>-<br>-      /*TCO Lock down */<br>-   tcobase = smbus_tco_regs();<br>-  tcocnt = inw(tcobase + TCO1_CNT);<br>-    tcocnt |= TCO_LOCK;<br>-  outw(tcocnt, tcobase + TCO1_CNT);<br> <br>  /* Display me status before we hide it */<br>     intel_me_status();<br></pre><p>To view, visit <a href="https://review.coreboot.org/21031">change 21031</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21031"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iec9e3075df01862f8558b303a458126c68202bff </div>
<div style="display:none"> Gerrit-Change-Number: 21031 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>