<p>John E. Kabat would like Marshall Dawson to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/21033">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/pi/hudson: Convert 48Mhz en to read/write32<br><br>Change-Id: I91e09757e5eea1eaf9b76921ad032ad2b79c14c5<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/southbridge/amd/pi/hudson/early_setup.c<br>1 file changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/21033/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c<br>index b5e753d..ae8b406 100644<br>--- a/src/southbridge/amd/pi/hudson/early_setup.c<br>+++ b/src/southbridge/amd/pi/hudson/early_setup.c<br>@@ -260,18 +260,17 @@<br> <br> void hudson_clk_output_48Mhz(void)<br> {<br>-     u32 data, *memptr;<br>+   u32 ctrl;<br> <br>  /*<br>     * Enable the X14M_25M_48M_OSC pin and leaving it at it's default so<br>       * 48Mhz will be on ball AP13 (FT3b package)<br>   */<br>-  memptr = (u32 *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40 );<br>-      data = *memptr;<br>+      ctrl = read32((void *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40));<br> <br>      /* clear the OSCOUT1_ClkOutputEnb to enable the 48 Mhz clock */<br>-      data &= (u32)~(1<<2);<br>-      *memptr = data;<br>+      ctrl &= (u32)~(1<<2);<br>+      write32((void *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40), ctrl);<br> }<br> <br> static uintptr_t hudson_spibase(void)<br></pre><p>To view, visit <a href="https://review.coreboot.org/21033">change 21033</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21033"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I91e09757e5eea1eaf9b76921ad032ad2b79c14c5 </div>
<div style="display:none"> Gerrit-Change-Number: 21033 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John E. Kabat <sljkrr@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat@scarletltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>