<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20999">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Check for supported UART index<br><br>if UART index is 2 then Base address for LPSS UART2 is selected<br>else assert because cannonlake chrome design don't support legacy UART<br>selection.<br><br>Change-Id: I31b239e7e6b7e9ac8ea2fcfbcbd8cb148ef9e586<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/cannonlake/uart.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/20999/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/cannonlake/uart.c b/src/soc/intel/cannonlake/uart.c<br>index 38f499d..ce1241f 100644<br>--- a/src/soc/intel/cannonlake/uart.c<br>+++ b/src/soc/intel/cannonlake/uart.c<br>@@ -14,6 +14,7 @@<br>  */<br> <br> #include <assert.h><br>+#include <console/console.h><br> #include <console/uart.h><br> #include <device/pci_def.h><br> #include <intelblocks/gpio.h><br>@@ -79,6 +80,11 @@<br> <br> uintptr_t uart_platform_base(int idx)<br> {<br>+   /* Same base address for all debug port usage. In reality UART2<br>+       * is currently only supported. */<br>+   if (idx != 2)<br>+                die("unsupported UART index");<br>+<br>   /* We can only have one serial console at a time */<br>   return UART_DEBUG_BASE_ADDRESS;<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/20999">change 20999</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20999"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I31b239e7e6b7e9ac8ea2fcfbcbd8cb148ef9e586 </div>
<div style="display:none"> Gerrit-Change-Number: 20999 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>