<p>Pratikkumar V Prajapati has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21009">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel/common/sgx: Use data pointer of device_t to get microcode<br><br>Get microcode patch pointer from device_t struct of CPU.<br><br>Change-Id: I9196c30ec7ea52d7184a96b33835def197e2c799<br>Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati@intel.com><br>---<br>M src/soc/intel/common/block/include/intelblocks/sgx.h<br>M src/soc/intel/common/block/sgx/sgx.c<br>2 files changed, 12 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21009/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/common/block/include/intelblocks/sgx.h b/src/soc/intel/common/block/include/intelblocks/sgx.h<br>index cc2dc7f..9929f0f 100644<br>--- a/src/soc/intel/common/block/include/intelblocks/sgx.h<br>+++ b/src/soc/intel/common/block/include/intelblocks/sgx.h<br>@@ -25,7 +25,7 @@<br> /*<br>  * Configure SGX.<br>  */<br>-void sgx_configure(const void *microcode_patch);<br>+void sgx_configure(void);<br> <br> /*<br>  * Configure core PRMRR<br>diff --git a/src/soc/intel/common/block/sgx/sgx.c b/src/soc/intel/common/block/sgx/sgx.c<br>index 53a68cf..55cb272 100644<br>--- a/src/soc/intel/common/block/sgx/sgx.c<br>+++ b/src/soc/intel/common/block/sgx/sgx.c<br>@@ -13,6 +13,7 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>+#include <assert.h><br> #include <console/console.h><br> #include <chip.h><br> #include <cpu/x86/msr.h><br>@@ -156,13 +157,20 @@<br>     return 0;<br> }<br> <br>-void sgx_configure(const void *microcode_patch)<br>+void sgx_configure(void)<br> {<br>-    device_t dev = SA_DEV_ROOT;<br>+  device_t dev = dev_find_path(NULL, DEVICE_PATH_CPU_CLUSTER);<br>+ assert(dev != NULL);<br>+<br>       config_t *conf = dev->chip_info;<br> <br>        if (!conf->sgx_enable || !is_sgx_supported() || !is_prmrr_set()) {<br>                 printk(BIOS_ERR, "SGX: pre-conditions not met\n");<br>+         return;<br>+      }<br>+<br>+ if (!dev->data) {<br>+         printk(BIOS_ERR, "SGX: microcode not set in device struct\n");<br>              return;<br>       }<br> <br>@@ -177,7 +185,7 @@<br>     cpu_lock_sgx_memory();<br> <br>     /* Reload the microcode patch */<br>-     intel_microcode_load_unlocked(microcode_patch);<br>+      intel_microcode_load_unlocked(dev->data);<br> <br>       /* Lock the SGX feature */<br>    lock_sgx();<br></pre><p>To view, visit <a href="https://review.coreboot.org/21009">change 21009</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21009"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9196c30ec7ea52d7184a96b33835def197e2c799 </div>
<div style="display:none"> Gerrit-Change-Number: 21009 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>