<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20951">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Configure FSP to skip ME MBP step<br><br>We do not need or use the Management Engine MBP HOB so that<br>step can be skipped when FSP initializes the ME.<br><br>BUG=b:64479422<br>TEST=boot with FSP debug enabled binary and ensure that the<br>output indicates this step is being skipped:<br>Skipping MBP data due to SkipMbpHob set!<br><br>Change-Id: I5ea22ec4b8b47fa17b1cf2bf562337bfaad5ec0d<br>Signed-off-by: Duncan Laurie <dlaurie@google.com><br>---<br>M src/soc/intel/skylake/romstage/romstage_fsp20.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/20951/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/romstage/romstage_fsp20.c b/src/soc/intel/skylake/romstage/romstage_fsp20.c<br>index e439d734..c43bdc3 100644<br>--- a/src/soc/intel/skylake/romstage/romstage_fsp20.c<br>+++ b/src/soc/intel/skylake/romstage/romstage_fsp20.c<br>@@ -222,6 +222,9 @@<br> <br>       soc_memory_init_params(m_cfg, config);<br> <br>+    /* Skip creating Management Engine MBP HOB */<br>+        m_t_cfg->SkipMbpHob = 0x01;<br>+<br>     /* Enable DMI Virtual Channel for ME */<br>       m_t_cfg->DmiVcm = 0x01;<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/20951">change 20951</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20951"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5ea22ec4b8b47fa17b1cf2bf562337bfaad5ec0d </div>
<div style="display:none"> Gerrit-Change-Number: 20951 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>