<p>Alexander Morgan has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20919">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP] Porting Gigabyte GA-H61M-DS2. VGA and PCIe card issues.<br><br>Change-Id: I69792873861ab657c83a17f7ec0624a8092e588a<br>---<br>M src/northbridge/intel/sandybridge/gma.c<br>M src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c<br>2 files changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/20919/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c<br>index db24dda..1189160 100644<br>--- a/src/northbridge/intel/sandybridge/gma.c<br>+++ b/src/northbridge/intel/sandybridge/gma.c<br>@@ -32,6 +32,9 @@<br> #include "sandybridge.h"<br> #include "gma.h"<br> <br>+// Including this c directly to fix the definition error "i915lightup_sandy.<br>+#include "gma_sandybridge_lvds.c"<br>+<br> struct gt_powermeter {<br>  u16 reg;<br>      u32 value;<br>@@ -648,7 +651,7 @@<br>                                   physbase, &lightup_ok);<br>               } else {<br>                      lightup_ok = i915lightup_sandy(&conf->gfx, physbase,<br>-                                  iobase, mmiobase, graphics_base);<br>+                                    (u16) iobase, mmiobase, graphics_base);<br>               }<br>             if (lightup_ok)<br>                       gfx_set_init_done(1);<br>diff --git a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c<br>index c3139a9..9a1a4ad 100644<br>--- a/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c<br>+++ b/src/northbridge/intel/sandybridge/gma_sandybridge_lvds.c<br>@@ -134,7 +134,9 @@<br>           return 0;<br> <br>  if ((bridge_silicon_revision() & BASE_REV_MASK) == BASE_REV_IVB) {<br>-               return i915lightup_ivy(info, physbase, piobase, mmio, lfb);<br>+// Commenting this call out. My board is sandy and this non-definition<br>+// breaks build.<br>+//            return i915lightup_ivy(info, physbase, piobase, mmio, lfb);<br>   }<br> <br>  write32(mmio + 0x00070080, 0x00000000);<br></pre><p>To view, visit <a href="https://review.coreboot.org/20919">change 20919</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20919"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I69792873861ab657c83a17f7ec0624a8092e588a </div>
<div style="display:none"> Gerrit-Change-Number: 20919 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alexander Morgan <xamboni@protonmail.com> </div>