<p>Patrick Rudolph <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20913">View Change</a></p><p>Patch set 3:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Why don't you use existing interface to make coreboot compatible with tpacpi-bat and thinkpad_acpi? They use the following ACPI methods:</p><ul><li>BCCS</li><li>BCSS</li><li>BICS</li><li>BDSS</li><li>PSSS</li><li>They allow to set thresholds, inhibit charge, peak shift, ...</li></ul><ul style="list-style: none; padding-left: 20px;"></ul><p>To view, visit <a href="https://review.coreboot.org/20913">change 20913</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20913"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia049407cea7a60887ecba7b7c96e5000473865dd </div>
<div style="display:none"> Gerrit-Change-Number: 20913 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 09 Aug 2017 07:11:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>