<p>Caveh Jalali has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20881">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add __must_check to */compiler.h<br><br>the __must_check function attribute is pretty much straight from the<br>linux kernel - used to encourage callers to consume function return<br>values.<br><br>Change-Id: I1812d957b745d6bebe2a8d34a9c4862316aa8530<br>Signed-off-by: Caveh Jalali <caveh@google.com><br>---<br>M payloads/libpayload/include/compiler.h<br>M src/include/compiler.h<br>M util/cbfstool/compiler.h<br>M util/cbmem/compiler.h<br>4 files changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/20881/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/payloads/libpayload/include/compiler.h b/payloads/libpayload/include/compiler.h<br>index f218725..a830239 100644<br>--- a/payloads/libpayload/include/compiler.h<br>+++ b/payloads/libpayload/include/compiler.h<br>@@ -24,5 +24,6 @@<br> <br> #define __aligned(x) __attribute__((aligned(x)))<br> #define __always_unused __attribute__((unused))<br>+#define __must_check __attribute__((warn_unused_result))<br> <br> #endif<br>diff --git a/src/include/compiler.h b/src/include/compiler.h<br>index f218725..a830239 100644<br>--- a/src/include/compiler.h<br>+++ b/src/include/compiler.h<br>@@ -24,5 +24,6 @@<br> <br> #define __aligned(x) __attribute__((aligned(x)))<br> #define __always_unused __attribute__((unused))<br>+#define __must_check __attribute__((warn_unused_result))<br> <br> #endif<br>diff --git a/util/cbfstool/compiler.h b/util/cbfstool/compiler.h<br>index f218725..a830239 100644<br>--- a/util/cbfstool/compiler.h<br>+++ b/util/cbfstool/compiler.h<br>@@ -24,5 +24,6 @@<br> <br> #define __aligned(x) __attribute__((aligned(x)))<br> #define __always_unused __attribute__((unused))<br>+#define __must_check __attribute__((warn_unused_result))<br> <br> #endif<br>diff --git a/util/cbmem/compiler.h b/util/cbmem/compiler.h<br>index f218725..a830239 100644<br>--- a/util/cbmem/compiler.h<br>+++ b/util/cbmem/compiler.h<br>@@ -24,5 +24,6 @@<br> <br> #define __aligned(x) __attribute__((aligned(x)))<br> #define __always_unused __attribute__((unused))<br>+#define __must_check __attribute__((warn_unused_result))<br> <br> #endif<br></pre><p>To view, visit <a href="https://review.coreboot.org/20881">change 20881</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20881"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1812d957b745d6bebe2a8d34a9c4862316aa8530 </div>
<div style="display:none"> Gerrit-Change-Number: 20881 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Caveh Jalali <caveh@google.com> </div>