<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20876">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">payloads/coreinfo: Free buffer before returning<br><br>Fixes coverity issue 1373370 - Resource leak<br><br>Change-Id: I71e0d3ae7f9152e1f89f8b3206526f0d344e0351<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M payloads/coreinfo/timestamps_module.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/20876/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/payloads/coreinfo/timestamps_module.c b/payloads/coreinfo/timestamps_module.c<br>index 020fcc6..fda5a96 100644<br>--- a/payloads/coreinfo/timestamps_module.c<br>+++ b/payloads/coreinfo/timestamps_module.c<br>@@ -210,8 +210,10 @@<br>   g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0);<br> <br>       g_buf = malloc(chars_count);<br>- if (!g_buf)<br>+  if (!g_buf) {<br>+                free(buffer);<br>                 return -3;<br>+   }<br> <br>  if (sanitize_buffer_for_display(buffer, buff_cur + 1, g_buf,<br>                          chars_count, SCREEN_X) < 0) {<br></pre><p>To view, visit <a href="https://review.coreboot.org/20876">change 20876</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20876"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I71e0d3ae7f9152e1f89f8b3206526f0d344e0351 </div>
<div style="display:none"> Gerrit-Change-Number: 20876 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>