<p>Lin Huang has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20871">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rockchip: rk3399: Correct rk3399 pmu gpio pull setting<br><br>In rk3399 pmu gpio pull register there have enable bit,<br>we need to handle these bit to get right setting.<br><br>BRANCH=None<br>BUG=None<br>TEST=boot from scarlet<br><br>Change-Id: Ibe391273d58ab35df993e149187d67497fcf2acc<br>Signed-off-by: Lin Huang <hl@rock-chips.com><br>---<br>M src/soc/rockchip/common/gpio.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/20871/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/rockchip/common/gpio.c b/src/soc/rockchip/common/gpio.c<br>index 3c77c3f..5323095 100644<br>--- a/src/soc/rockchip/common/gpio.c<br>+++ b/src/soc/rockchip/common/gpio.c<br>@@ -30,7 +30,7 @@<br> static void gpio_set_pull(gpio_t gpio, enum gpio_pull pull)<br> {<br>  u32 pull_val = gpio_get_pull_val(gpio, pull);<br>-        if (is_pmu_gpio(gpio))<br>+       if (is_pmu_gpio(gpio) && IS_ENABLED(CONFIG_SOC_ROCKCHIP_RK3288))<br>              clrsetbits_le32(gpio_grf_reg(gpio), 3 << (gpio.idx * 2),<br>                                pull_val << (gpio.idx * 2));<br>    else<br></pre><p>To view, visit <a href="https://review.coreboot.org/20871">change 20871</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20871"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibe391273d58ab35df993e149187d67497fcf2acc </div>
<div style="display:none"> Gerrit-Change-Number: 20871 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lin Huang <hl@rock-chips.com> </div>