<p>Keith Hui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20868">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">440BX boards: Use combined RAM init routine.<br><br>Change all 440BX boards to use the recently combined RAM init<br>routine[1].<br><br>A couple 440BX boards were left out of the cleanup job at [2].<br>They now receive this cleanup as well.<br><br>[1] https://review.coreboot.org/20676<br>[2] https://review.coreboot.org/20693<br><br>Change-Id: I699db882189f99018d4a6fdcb00f9438b2a7a1bc<br>Signed-off-by: Keith Hui <buurin@gmail.com><br>---<br>M src/mainboard/a-trend/atc-6220/romstage.c<br>M src/mainboard/a-trend/atc-6240/romstage.c<br>M src/mainboard/asus/p2b-ds/romstage.c<br>M src/mainboard/asus/p2b-ls/romstage.c<br>M src/mainboard/asus/p2b/romstage.c<br>M src/mainboard/asus/p3b-f/romstage.c<br>M src/mainboard/azza/pt-6ibd/romstage.c<br>M src/mainboard/compaq/deskpro_en_sff_p600/romstage.c<br>M src/mainboard/gigabyte/ga-6bxc/romstage.c<br>M src/mainboard/gigabyte/ga-6bxe/romstage.c<br>M src/mainboard/msi/ms6119/romstage.c<br>M src/mainboard/msi/ms6147/romstage.c<br>M src/mainboard/msi/ms6156/romstage.c<br>M src/mainboard/nokia/ip530/romstage.c<br>M src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>M src/mainboard/tyan/s1846/romstage.c<br>16 files changed, 16 insertions(+), 72 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/20868/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/a-trend/atc-6220/romstage.c b/src/mainboard/a-trend/atc-6220/romstage.c<br>index 6cf86c1..70e4323 100644<br>--- a/src/mainboard/a-trend/atc-6220/romstage.c<br>+++ b/src/mainboard/a-trend/atc-6220/romstage.c<br>@@ -39,8 +39,5 @@<br>         report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/a-trend/atc-6240/romstage.c b/src/mainboard/a-trend/atc-6240/romstage.c<br>index cbb0207..8dd9686 100644<br>--- a/src/mainboard/a-trend/atc-6240/romstage.c<br>+++ b/src/mainboard/a-trend/atc-6240/romstage.c<br>@@ -39,8 +39,5 @@<br>       report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c<br>index 809f1f6..1d34bd9 100644<br>--- a/src/mainboard/asus/p2b-ds/romstage.c<br>+++ b/src/mainboard/asus/p2b-ds/romstage.c<br>@@ -39,8 +39,5 @@<br>   report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c<br>index 5ed878f..ecfc8b8 100644<br>--- a/src/mainboard/asus/p2b-ls/romstage.c<br>+++ b/src/mainboard/asus/p2b-ls/romstage.c<br>@@ -40,8 +40,5 @@<br>   report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c<br>index 6cf86c1..70e4323 100644<br>--- a/src/mainboard/asus/p2b/romstage.c<br>+++ b/src/mainboard/asus/p2b/romstage.c<br>@@ -39,8 +39,5 @@<br>       report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c<br>index bb16c78..0bb5bca 100644<br>--- a/src/mainboard/asus/p3b-f/romstage.c<br>+++ b/src/mainboard/asus/p3b-f/romstage.c<br>@@ -76,10 +76,7 @@<br> <br>   enable_spd();<br> <br>-     dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> <br>        disable_spd();<br> }<br>diff --git a/src/mainboard/azza/pt-6ibd/romstage.c b/src/mainboard/azza/pt-6ibd/romstage.c<br>index c4cfbec..eb031e0 100644<br>--- a/src/mainboard/azza/pt-6ibd/romstage.c<br>+++ b/src/mainboard/azza/pt-6ibd/romstage.c<br>@@ -14,7 +14,6 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br>@@ -42,8 +41,5 @@<br>     report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c b/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c<br>index 7a59b1b..712ea96 100644<br>--- a/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c<br>+++ b/src/mainboard/compaq/deskpro_en_sff_p600/romstage.c<br>@@ -14,15 +14,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br>-#include <arch/io.h><br> #include <device/pnp_def.h><br>-#include <stdlib.h><br> #include <console/console.h><br> #include <southbridge/intel/i82371eb/i82371eb.h><br> #include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br> #include <cpu/x86/bist.h><br> #include <cpu/intel/romstage.h><br> /* FIXME: This should be PC97307 (but it's buggy at the moment)! */<br>@@ -45,8 +41,5 @@<br>       report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/gigabyte/ga-6bxc/romstage.c b/src/mainboard/gigabyte/ga-6bxc/romstage.c<br>index 425a615..7f85e0e 100644<br>--- a/src/mainboard/gigabyte/ga-6bxc/romstage.c<br>+++ b/src/mainboard/gigabyte/ga-6bxc/romstage.c<br>@@ -39,8 +39,5 @@<br>       report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/gigabyte/ga-6bxe/romstage.c b/src/mainboard/gigabyte/ga-6bxe/romstage.c<br>index 85b36b9..d4bdbe8 100644<br>--- a/src/mainboard/gigabyte/ga-6bxe/romstage.c<br>+++ b/src/mainboard/gigabyte/ga-6bxe/romstage.c<br>@@ -40,8 +40,5 @@<br>       report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/msi/ms6119/romstage.c b/src/mainboard/msi/ms6119/romstage.c<br>index 7791e91..1d34bd9 100644<br>--- a/src/mainboard/msi/ms6119/romstage.c<br>+++ b/src/mainboard/msi/ms6119/romstage.c<br>@@ -14,7 +14,6 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br>@@ -40,8 +39,5 @@<br>        report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/msi/ms6147/romstage.c b/src/mainboard/msi/ms6147/romstage.c<br>index 8cda4b8..6ac5ae1 100644<br>--- a/src/mainboard/msi/ms6147/romstage.c<br>+++ b/src/mainboard/msi/ms6147/romstage.c<br>@@ -40,8 +40,5 @@<br>       report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/msi/ms6156/romstage.c b/src/mainboard/msi/ms6156/romstage.c<br>index cf39f52..6a3b7f4 100644<br>--- a/src/mainboard/msi/ms6156/romstage.c<br>+++ b/src/mainboard/msi/ms6156/romstage.c<br>@@ -14,7 +14,6 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br>@@ -40,8 +39,5 @@<br>        report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/nokia/ip530/romstage.c b/src/mainboard/nokia/ip530/romstage.c<br>index e647aae..fa0585d 100644<br>--- a/src/mainboard/nokia/ip530/romstage.c<br>+++ b/src/mainboard/nokia/ip530/romstage.c<br>@@ -38,8 +38,5 @@<br>   report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>index 770a7cb..0bb1ab2 100644<br>--- a/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>+++ b/src/mainboard/soyo/sy-6ba-plus-iii/romstage.c<br>@@ -14,7 +14,6 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br> #include <device/pci_def.h><br> #include <device/pnp_def.h><br> #include <console/console.h><br>@@ -39,8 +38,5 @@<br>        report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br>diff --git a/src/mainboard/tyan/s1846/romstage.c b/src/mainboard/tyan/s1846/romstage.c<br>index 4819b8a..28aac5d 100644<br>--- a/src/mainboard/tyan/s1846/romstage.c<br>+++ b/src/mainboard/tyan/s1846/romstage.c<br>@@ -38,8 +38,5 @@<br>       report_bist_failure(bist);<br> <br>         enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>+      sdram_initialize();<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/20868">change 20868</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20868"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I699db882189f99018d4a6fdcb00f9438b2a7a1bc </div>
<div style="display:none"> Gerrit-Change-Number: 20868 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Hui <buurin@gmail.com> </div>