<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20820">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma hsw+: Revise Has_DDI_D flag<br><br>The GFX Programmer's Reference Manuals (PRMs) aren't clear on this but<br>it's pretty clear from the processor datasheets which SKUs expose which<br>pins: All U/Y processors lack DDI D.<br><br>Change-Id: I84c40b6bc01091de8a512e21354243c74643e0f5<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M common/hw-gfx-gma-config.ads.template<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/20/20820/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template<br>index 2bb916a..aba00bb 100644<br>--- a/common/hw-gfx-gma-config.ads.template<br>+++ b/common/hw-gfx-gma-config.ads.template<br>@@ -86,15 +86,15 @@<br>                                                   and CPU_Var = ULT) or<br>                                                  CPU >= Skylake;<br> <br>-   Has_DDI_D               : constant Boolean := (CPU in Haswell .. Broadwell<br>-                                                  and CPU_Var = Normal)<br>-                                                 or CPU >= Skylake;<br>+   Has_DDI_PHYs            : constant Boolean := CPU = Broxton;<br>+<br>+   Has_DDI_D               : constant Boolean := CPU >= Haswell and<br>+                                                 CPU_Var = Normal and<br>+                                                 not Has_DDI_PHYs;<br> <br>    Has_Low_Voltage_Swing   : constant Boolean := CPU >= Broxton;<br> <br>    Need_DP_Aux_Mutex       : constant Boolean := False; -- Skylake & (PSR | GTC)<br>-<br>-   Has_DDI_PHYs            : constant Boolean := CPU = Broxton;<br> <br>    ----- GMBUS: -----------<br>    Ungate_GMBUS_Unit_Level : constant Boolean := CPU >= Skylake;<br></pre><p>To view, visit <a href="https://review.coreboot.org/20820">change 20820</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20820"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I84c40b6bc01091de8a512e21354243c74643e0f5 </div>
<div style="display:none"> Gerrit-Change-Number: 20820 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>