<p>James Ye <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20814">View Change</a></p><p>Patch set 2:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20814/2/src/northbridge/intel/sandybridge/gma.c">File src/northbridge/intel/sandybridge/gma.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20814/2/src/northbridge/intel/sandybridge/gma.c@270">Patch Set #2, Line 270:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">        case 0x80860152:                /* IVB Desktop */<br>     case 0x80860156:                /* IVB Mobile */<br>      case 0x80860162:                /* IVB Desktop */<br>     case 0x80860166:                /* IVB Mobile */<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Inconsistent indenting?</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20814/2/util/autoport/sandybridge.go">File util/autoport/sandybridge.go:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20814/2/util/autoport/sandybridge.go@145">Patch Set #2, Line 145:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">               0x0112, 0x0116, 0x0122, 0x0126,<br>               0x0152, 0x0156, 0x0162, 0x0166,<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should probably be spaces after the comma, not a tab.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20814">change 20814</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20814"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 </div>
<div style="display:none"> Gerrit-Change-Number: 20814 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: James Ye <jye836@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 29 Jul 2017 01:37:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>