<p>Iru Cai <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20501">View Change</a></p><p>Patch set 7:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb">File src/mainboard/hp/8460p/devicetree.cb:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb@17">Patch Set #6, Line 17:</a> <code style="font-family:monospace,monospace">chip northbridge/intel/sandybridge</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">remove all FIXMEs</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't know if these gfx.did values are correct, although the display just works.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c">File src/mainboard/hp/8460p/romstage.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c@34">Patch Set #6, Line 34:</a> <code style="font-family:monospace,monospace">{</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">On Ivybridge I've done:</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20501">change 20501</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20501"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 </div>
<div style="display:none"> Gerrit-Change-Number: 20501 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 28 Jul 2017 13:27:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>