<p>V Sowmya has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20495">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboardb/google/poppy: Add ACPI objects for NVMEM device GT24C16S<br><br>The GT24C16S is an industrial standard electrically erasable<br>programmable read only memory (EEPROM) and this patch adds ACPI<br>objects and power resources for NVMEM device.<br><br>BUG=b:38326541<br>BRANCH=none<br>TEST=Build and boot soraka. Dump and verify that the generated DSDT table<br>has the required entries. Read the NVMEM content via sysfs interface.<br><br>Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae<br>Signed-off-by: V Sowmya <v.sowmya@intel.com><br>---<br>M src/mainboard/google/poppy/acpi/mipi_camera.asl<br>1 file changed, 65 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/20495/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/acpi/mipi_camera.asl b/src/mainboard/google/poppy/acpi/mipi_camera.asl<br>index d32e7a3..b414040 100644<br>--- a/src/mainboard/google/poppy/acpi/mipi_camera.asl<br>+++ b/src/mainboard/google/poppy/acpi/mipi_camera.asl<br>@@ -278,8 +278,8 @@<br> }<br> }<br> } ElseIf (LEqual (Arg0, 1)) {<br>- /* Increment only if VSIC < 3 */<br>- If (LLess (VSIC, 3)) {<br>+ /* Increment only if VSIC < 4 */<br>+ If (LLess (VSIC, 4)) {<br> /* Turn on VSIO */<br> If (LEqual (VSIC, Zero)) {<br> VSIO = 3<br>@@ -480,6 +480,47 @@<br> Return (STA)<br> }<br> }<br>+<br>+ /* Power resource methods for NVM */<br>+ PowerResource (NVMP, 0, 0) {<br>+ Name (STA, 0)<br>+ Method (_ON, 0, Serialized) {<br>+ If (LEqual (AVBL, 1)) {<br>+ If (LEqual (STA, 0)) {<br>+ /* Enable VSIO regulator +<br>+ daisy chain */<br>+ DOVD(1)<br>+ if (LNotEqual (IOVA, 52)) {<br>+ /* Set VSIO value as<br>+ 1.8006 V */<br>+ IOVA = 52<br>+ }<br>+ if (LNotEqual (SIOV, 52)) {<br>+ /* Set VSIO value as<br>+ 1.8006 V */<br>+ SIOV = 52<br>+ }<br>+ Sleep(3)<br>+<br>+ STA = 1<br>+ }<br>+ }<br>+ }<br>+<br>+ Method (_OFF, 0, Serialized) {<br>+ If (LEqual (AVBL, 1)) {<br>+ If (LEqual (STA, 1)) {<br>+ DOVD(0) /* Disable regulator */<br>+ Sleep(1)<br>+ STA = 0<br>+ }<br>+ }<br>+ }<br>+<br>+ Method (_STA, 0, NotSerialized) {<br>+ Return (STA)<br>+ }<br>+ }<br> }<br> <br> Device (CAM0)<br>@@ -612,6 +653,28 @@<br> Name (_PR0, Package () { ^PMIC.VCMP })<br> Name (_PR3, Package () { ^PMIC.VCMP })<br> }<br>+<br>+ Device (NVM0)<br>+ {<br>+ Name (_HID, "GIAN0001") /* _HID: Hardware ID */<br>+ Name (_UID, Zero) /* _UID: Unique ID */<br>+ Name (_DDN, "Giantec GT24C16S") /* _DDN: DOS Device Name */<br>+ Method (_STA, 0, NotSerialized) /* _STA: Status */<br>+ {<br>+ Return (0x0F)<br>+ }<br>+<br>+ Name (_DEP, Package() {\_SB.PCI0.I2C2.PMIC})<br>+ Name (_CRS, ResourceTemplate ()<br>+ {<br>+ I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80,<br>+ AddressingMode7Bit, "\\_SB.PCI0.I2C2",<br>+ 0x00, ResourceConsumer, ,)<br>+ })<br>+<br>+ Name (_PR0, Package () { ^PMIC.NVMP })<br>+ Name (_PR3, Package () { ^PMIC.NVMP })<br>+ }<br> }<br> <br> Scope (\_SB.PCI0.I2C4)<br></pre><p>To view, visit <a href="https://review.coreboot.org/20495">change 20495</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20495"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae </div>
<div style="display:none"> Gerrit-Change-Number: 20495 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: V Sowmya <v.sowmya@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>