<p>Marshall Dawson has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20791">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge: Convert 48Mhz enable to read/write32<br><br>Use the appropriate read32() and write32() calls.  Remove unnecessary<br>cast.<br><br>Change-Id: Ib5430bdb30844d3508a09ddb77a969c0628f6c7d<br>Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com><br>---<br>M src/soc/amd/stoneyridge/early_setup.c<br>1 file changed, 4 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/20791/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/stoneyridge/early_setup.c b/src/soc/amd/stoneyridge/early_setup.c<br>index ca3447f..f1539ea 100644<br>--- a/src/soc/amd/stoneyridge/early_setup.c<br>+++ b/src/soc/amd/stoneyridge/early_setup.c<br>@@ -224,18 +224,17 @@<br> <br> void hudson_clk_output_48Mhz(void)<br> {<br>-    u32 data, *memptr;<br>+   u32 ctrl;<br> <br>  /*<br>     * Enable the X14M_25M_48M_OSC pin and leaving it at it's default so<br>       * 48Mhz will be on ball AP13 (FT3b package)<br>   */<br>-  memptr = (u32 *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40);<br>-       data = *memptr;<br>+      ctrl = read32((void *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40));<br> <br>      /* clear the OSCOUT1_ClkOutputEnb to enable the 48 Mhz clock */<br>-      data &= (u32)~(1<<2);<br>-      *memptr = data;<br>+      ctrl &= ~(1<<2);<br>+   write32((void *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40), ctrl);<br> }<br> <br> static uintptr_t hudson_spibase(void)<br></pre><p>To view, visit <a href="https://review.coreboot.org/20791">change 20791</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20791"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib5430bdb30844d3508a09ddb77a969c0628f6c7d </div>
<div style="display:none"> Gerrit-Change-Number: 20791 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>