<p>Lijian Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20775">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Correct gpio definition<br><br>Correct port id using by GPIO community 3 for CNL-LP.<br>Correct Number of Double word for each pad to 4.<br><br>Change-Id: I717d1ffba8e6722543f4cf8083fe6145fa85e184<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>---<br>M src/soc/intel/cannonlake/gpio.c<br>M src/soc/intel/cannonlake/include/soc/gpio_defs.h<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/20775/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/cannonlake/gpio.c b/src/soc/intel/cannonlake/gpio.c<br>index 2dd90f9..68b137d 100644<br>--- a/src/soc/intel/cannonlake/gpio.c<br>+++ b/src/soc/intel/cannonlake/gpio.c<br>@@ -75,7 +75,7 @@<br>             .reset_map = rst_map,<br>                 .num_reset_vals = ARRAY_SIZE(rst_map),<br>        }, { /* GPP C, E */<br>-          .port = PID_GPIOCOM3,<br>+                .port = PID_GPIOCOM4,<br>                 .first_pad = GPP_C0,<br>          .last_pad = GPP_E23,<br>          .num_gpi_regs = NUM_GPIO_COM3_GPI_REGS,<br>diff --git a/src/soc/intel/cannonlake/include/soc/gpio_defs.h b/src/soc/intel/cannonlake/include/soc/gpio_defs.h<br>index 46ab1d9..6e84f83 100644<br>--- a/src/soc/intel/cannonlake/include/soc/gpio_defs.h<br>+++ b/src/soc/intel/cannonlake/include/soc/gpio_defs.h<br>@@ -22,7 +22,7 @@<br> #include <soc/gpio_soc_defs.h><br> <br> <br>-#define GPIO_NUM_PAD_CFG_REGS   2 /* DW0, DW1 */<br>+#define GPIO_NUM_PAD_CFG_REGS   4 /* DW0, DW1, DW2, DW3 */<br> <br> #define NUM_GPIO_COMx_GPI_REGS(n) \<br>             (ALIGN_UP((n), GPIO_MAX_NUM_PER_GROUP) / GPIO_MAX_NUM_PER_GROUP)<br></pre><p>To view, visit <a href="https://review.coreboot.org/20775">change 20775</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20775"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I717d1ffba8e6722543f4cf8083fe6145fa85e184 </div>
<div style="display:none"> Gerrit-Change-Number: 20775 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>