<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20749">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/fsp2_0: Add NULL check while locating hob list ptr<br><br>Assert incase unable to locate hob list pointer due to cbmem<br>is not available.<br><br>Change-Id: I17f54b07ab149ae06d09226ed9063189d829efe2<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/drivers/intel/fsp2_0/hand_off_block.c<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/20749/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c<br>index 4a8e73a..2d7e209 100644<br>--- a/src/drivers/intel/fsp2_0/hand_off_block.c<br>+++ b/src/drivers/intel/fsp2_0/hand_off_block.c<br>@@ -105,10 +105,14 @@<br> static void save_hob_list(int is_recovery)<br> {<br> uint32_t *cbmem_loc;<br>+ const void *hob_list;<br> cbmem_loc = cbmem_add(CBMEM_ID_FSP_RUNTIME, sizeof(*cbmem_loc));<br> if (cbmem_loc == NULL)<br> die("Error: Could not add cbmem area for hob list.\n");<br>- *cbmem_loc = (uintptr_t)fsp_get_hob_list();<br>+ hob_list = fsp_get_hob_list();<br>+ if (!hob_list)<br>+ die("Error: Could not locate hob list pointer.\n");<br>+ *cbmem_loc = (uintptr_t)hob_list;<br> }<br> <br> ROMSTAGE_CBMEM_INIT_HOOK(save_hob_list);<br>@@ -167,6 +171,9 @@<br> const struct hob_resource *fsp_mem;<br> const void *hob_list = fsp_get_hob_list();<br> <br>+ if (!hob_list)<br>+ return -1;<br>+<br> range_entry_init(re, 0, 0, 0);<br> <br> fsp_mem = find_resource_hob_by_guid(hob_list, guid);<br></pre><p>To view, visit <a href="https://review.coreboot.org/20749">change 20749</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20749"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I17f54b07ab149ae06d09226ed9063189d829efe2 </div>
<div style="display:none"> Gerrit-Change-Number: 20749 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>