<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20734">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/include: Add guards on all header files<br><br>Change-Id: I2d7d4e0b25f2cf3eef2040f89d5ebc711909cdd7<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/include/cpu/amd/model_10xxx_rev.h<br>M src/include/cpu/amd/model_fxx_rev.h<br>M src/include/cpu/amd/sc520.h<br>M src/include/cpu/x86/post_code.h<br>M src/include/device/pci_ids.h<br>M src/include/spd_ddr2.h<br>M src/include/sys/types.h<br>7 files changed, 32 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/20734/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/include/cpu/amd/model_10xxx_rev.h b/src/include/cpu/amd/model_10xxx_rev.h<br>index 7f07e98..c6fa8f6 100644<br>--- a/src/include/cpu/amd/model_10xxx_rev.h<br>+++ b/src/include/cpu/amd/model_10xxx_rev.h<br>@@ -13,8 +13,13 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>+#ifndef __CPU_AMD_MODEL_10XXX_REV_H__<br>+#define __CPU_AMD_MODEL_10XXX_REV_H__<br>+<br> #include <arch/cpu.h><br> <br> int init_processor_name(void);<br> <br> /* place holder for Family 10 revision code */<br>+<br>+#endif /* __CPU_AMD_MODEL_10XXX_REV_H__ */<br>diff --git a/src/include/cpu/amd/model_fxx_rev.h b/src/include/cpu/amd/model_fxx_rev.h<br>index 828e51a..6fb6194 100644<br>--- a/src/include/cpu/amd/model_fxx_rev.h<br>+++ b/src/include/cpu/amd/model_fxx_rev.h<br>@@ -1,3 +1,6 @@<br>+#ifndef __CPU_AMD_MODEL_FXX_REV_H__<br>+#define __CPU_AMD_MODEL_FXX_REV_H__<br>+<br> #include <arch/cpu.h><br> #include <arch/io.h><br> <br>@@ -125,3 +128,4 @@<br> int is_cpu_f0_in_bsp(int nodeid);<br> <br> #endif<br>+#endif /* __CPU_AMD_MODEL_FXX_REV_H__ */<br>diff --git a/src/include/cpu/amd/sc520.h b/src/include/cpu/amd/sc520.h<br>index 4e748be..5d72d69 100644<br>--- a/src/include/cpu/amd/sc520.h<br>+++ b/src/include/cpu/amd/sc520.h<br>@@ -1,4 +1,8 @@<br> /* handy dandy stuff for the sc520 MMCR */<br>+<br>+#ifndef __CPU_AMD_SC520_H__<br>+#define __CPU_AMD_SC520_H__<br>+<br> /* default location of the MMCR */<br> #define MMCR 0xfffef000<br> <br>@@ -309,3 +313,5 @@<br> <br> <br> #define MMCRDEFAULT ((struct mmcr *) 0xfffef000)<br>+<br>+#endif /* __CPU_AMD_SC520_H__ */<br>diff --git a/src/include/cpu/x86/post_code.h b/src/include/cpu/x86/post_code.h<br>index cd3d159..76a415d 100644<br>--- a/src/include/cpu/x86/post_code.h<br>+++ b/src/include/cpu/x86/post_code.h<br>@@ -1,3 +1,5 @@<br>+#ifndef __X86_POST_CODE_H__<br>+#define __X86_POST_CODE_H__<br> <br> #include <console/post_codes.h><br> <br>@@ -10,3 +12,4 @@<br> #else<br> #define post_code(value)<br> #endif<br>+#endif /* __X86_POST_CODE_H__ */<br>diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h<br>index f89a6aa..323bc13 100644<br>--- a/src/include/device/pci_ids.h<br>+++ b/src/include/device/pci_ids.h<br>@@ -4,6 +4,9 @@<br>  *       Please keep sorted.<br>  */<br> <br>+#ifndef __DEVICE_PCI_IDS_H__<br>+#define __DEVICE_PCI_IDS_H__<br>+<br> /* Device classes and subclasses */<br> <br> #define PCI_CLASS_NOT_DEFINED          0x0000<br>@@ -3077,3 +3080,4 @@<br> #define PCI_DEVICE_ID_AMD_VIPER_7412    0x7412<br> <br> /* END OLDER USAGE */<br>+#endif /* __DEVICE_PCI_IDS_H__ */<br>diff --git a/src/include/spd_ddr2.h b/src/include/spd_ddr2.h<br>index 848cc5d..724c996 100644<br>--- a/src/include/spd_ddr2.h<br>+++ b/src/include/spd_ddr2.h<br>@@ -14,6 +14,9 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>+#ifndef __SPD_DDR2_H__<br>+#define __SPD_DDR2_H__<br>+<br> /* SPDs for DDR2 SDRAM */<br> #define SPD_MEM_TYPE    2<br>     #define SPD_MEM_TYPE_SDRAM_DDR  0x07<br>@@ -111,3 +114,5 @@<br> #define SPD_TRFC    42<br> <br> #define SPD_TREF        12<br>+<br>+#endif /* __SPD_DDR2_H__ */<br>diff --git a/src/include/sys/types.h b/src/include/sys/types.h<br>index fa95d57..69968dd 100644<br>--- a/src/include/sys/types.h<br>+++ b/src/include/sys/types.h<br>@@ -1 +1,6 @@<br>+#ifndef __SYS_TYPES_H__<br>+#define __SYS_TYPES_H__<br>+<br> #include "../types.h"<br>+<br>+#endif /* __SYS_TYPES_H__ */<br></pre><p>To view, visit <a href="https://review.coreboot.org/20734">change 20734</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20734"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2d7d4e0b25f2cf3eef2040f89d5ebc711909cdd7 </div>
<div style="display:none"> Gerrit-Change-Number: 20734 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>