<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/20690">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">asus/p2b-f: Use romstage from asus/p2b-ls.<br><br>The romstage for both is line-for-line identical.<br>Merge both into P2B-LS so it benefits from my<br>modernization efforts.<br><br>Change-Id: I2d1a46236f83a4955ceb5e98b576cce0560f28df<br>Signed-off-by: Keith Hui <buurin@gmail.com><br>Reviewed-on: https://review.coreboot.org/20690<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/asus/p2b-f/romstage.c<br>1 file changed, 2 insertions(+), 36 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/asus/p2b-f/romstage.c b/src/mainboard/asus/p2b-f/romstage.c<br>index 80fd76c..31a100c 100644<br>--- a/src/mainboard/asus/p2b-f/romstage.c<br>+++ b/src/mainboard/asus/p2b-f/romstage.c<br>@@ -14,39 +14,5 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <stdlib.h><br>-#include <console/console.h><br>-#include <southbridge/intel/i82371eb/i82371eb.h><br>-#include <northbridge/intel/i440bx/raminit.h><br>-#include <delay.h><br>-#include <cpu/x86/bist.h><br>-#include <cpu/intel/romstage.h><br>-#include <superio/winbond/common/winbond.h><br>-/* FIXME: The ASUS P2B-F has a Winbond W83977EF, actually. */<br>-#include <superio/winbond/w83977tf/w83977tf.h><br>-#include <lib.h><br>-<br>-/* FIXME: The ASUS P2B-F has a Winbond W83977EF, actually. */<br>-#define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1)<br>-<br>-int spd_read_byte(unsigned int device, unsigned int address)<br>-{<br>- return smbus_read_byte(device, address);<br>-}<br>-<br>-void mainboard_romstage_entry(unsigned long bist)<br>-{<br>-      winbond_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);<br>-        console_init();<br>-      report_bist_failure(bist);<br>-<br>-        enable_smbus();<br>-      dump_spd_registers();<br>-        sdram_set_registers();<br>-       sdram_set_spd_registers();<br>-   sdram_enable();<br>-}<br>+/* Shares romstage with the better supported P2B-LS sibling. */<br>+#include "../p2b-ls/romstage.c"<br></pre><p>To view, visit <a href="https://review.coreboot.org/20690">change 20690</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20690"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2d1a46236f83a4955ceb5e98b576cce0560f28df </div>
<div style="display:none"> Gerrit-Change-Number: 20690 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Keith Hui <buurin@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>