<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20707">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sb/intel/common/gpio: Only set one bit at time<br><br>Make sure to set only one bit instead of arbitrary bits set in argument.<br><br>Change-Id: I39426193d15d8581f79bc2a45c0edb53b19a2cd3<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/southbridge/intel/common/gpio.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/20707/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/southbridge/intel/common/gpio.c b/src/southbridge/intel/common/gpio.c<br>index d861383..caf24f4 100644<br>--- a/src/southbridge/intel/common/gpio.c<br>+++ b/src/southbridge/intel/common/gpio.c<br>@@ -142,7 +142,8 @@<br> <br>   config = inl(gpio_base + gpio_reg_offsets[index]);<br>    config &= ~(1 << bit);<br>-     config |= value << bit;<br>+        if (value != 0)<br>+              config |= (1 << bit);<br>   outl(config, gpio_base + gpio_reg_offsets[index]);<br> }<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/20707">change 20707</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20707"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I39426193d15d8581f79bc2a45c0edb53b19a2cd3 </div>
<div style="display:none"> Gerrit-Change-Number: 20707 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>