<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20678">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Perform LPC offset read after lockdown operation<br><br>This patch is to provide an additional read LPC pci offset register<br>BIOS_CONTROL (BC) - offset 0xDC to ensure that the last write is<br>successful.<br><br>Change-Id: I308c0622d348fc96c410a04ab4081bb6af98e874<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/skylake/finalize.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/20678/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c<br>index 171d92e..34f26eb 100644<br>--- a/src/soc/intel/skylake/finalize.c<br>+++ b/src/soc/intel/skylake/finalize.c<br>@@ -185,6 +185,9 @@<br>                              pci_read_config8(PCH_DEV_LPC,<br>                                                  BIOS_CNTL) | LPC_BC_LE);<br> <br>+               /* Ensure an additional read back after performing lock down */<br>+              pci_read_config8(PCH_DEV_LPC, BIOS_CNTL);<br>+<br>          fast_spi_set_lock_enable();<br>   }<br> <br>@@ -194,6 +197,9 @@<br>                               pci_read_config8(PCH_DEV_LPC,<br>                                                  BIOS_CNTL) | LPC_BC_EISS);<br> <br>+             /* Ensure an additional read back after performing lock down */<br>+              pci_read_config8(PCH_DEV_LPC, BIOS_CNTL);<br>+<br>          fast_spi_set_eiss();<br>  }<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/20678">change 20678</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20678"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I308c0622d348fc96c410a04ab4081bb6af98e874 </div>
<div style="display:none"> Gerrit-Change-Number: 20678 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>