<p>V Sowmya has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20662">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kblrvp: Configure ports and endpoints for sensor and CIO2 devices<br><br>Bind the camera sensor and CIO2 devices through the ports and endpoints<br>configuration available in _DSD ACPI object.<br><br>* Port represents an interface in a device.<br>* Endpoint represents a connection to that interface.<br><br>BUG=none<br>BRANCH=none<br>TEST=Build and boot kblrvp. Dump and verify that the generated DSDT table<br>has the required entries.<br><br>Change-Id: If328864dbb61586a4887c7fcae740a12eda7cc92<br>Signed-off-by: V Sowmya <v.sowmya@intel.com><br>---<br>A src/mainboard/intel/kblrvp/acpi/ipu_mainboard.asl<br>M src/mainboard/intel/kblrvp/acpi/mipi_camera.asl<br>M src/mainboard/intel/kblrvp/dsdt.asl<br>3 files changed, 155 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/20662/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/intel/kblrvp/acpi/ipu_mainboard.asl b/src/mainboard/intel/kblrvp/acpi/ipu_mainboard.asl<br>new file mode 100644<br>index 0000000..211ca43<br>--- /dev/null<br>+++ b/src/mainboard/intel/kblrvp/acpi/ipu_mainboard.asl<br>@@ -0,0 +1,74 @@<br>+/*<br>+ * This file is part of the coreboot project.<br>+ *<br>+ * Copyright (C) 2017 Intel Corporation.<br>+ *<br>+ * This program is free software; you can redistribute it and/or modify<br>+ * it under the terms of the GNU General Public License as published by<br>+ * the Free Software Foundation; version 2 of the License.<br>+ *<br>+ * This program is distributed in the hope that it will be useful,<br>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the<br>+ * GNU General Public License for more details.<br>+ */<br>+<br>+Scope (\_SB.PCI0.CIO2)<br>+{<br>+ /* Define two ports for CIO2 device where endpoint of port0<br>+ is connected to CAM0 and endpoint of port1 is connected to CAM1 */<br>+<br>+ Name (_DSD, Package () {<br>+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br>+ Package () {<br>+ Package () { "port0", "PRT0" },<br>+ Package () { "port1", "PRT1" },<br>+ }<br>+ })<br>+<br>+ Name (PRT0, Package () {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "port", 0 }, /* csi 0 */<br>+ },<br>+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br>+ Package () {<br>+ Package () { "endpoint0", "EP00" },<br>+ }<br>+ })<br>+<br>+ Name (EP00, Package() {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "endpoint", 0 },<br>+ Package () { "clock-lanes", 0 },<br>+ Package () { "data-lanes", Package () { 1, 2, 3, 4 } },<br>+ Package () { "remote-endpoint",<br>+ Package() { \_SB.PCI0.I2C2.CAM0, 0, 0 }<br>+ },<br>+ }<br>+ })<br>+<br>+ Name (PRT1, Package () {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "port", 1 }, /* csi 1 */<br>+ },<br>+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br>+ Package () {<br>+ Package () { "endpoint0", "EP10" },<br>+ }<br>+ })<br>+<br>+ Name (EP10, Package() {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "endpoint", 0 },<br>+ Package () { "clock-lanes", 0 },<br>+ Package () { "data-lanes", Package () { 1, 2 } },<br>+ Package () { "remote-endpoint",<br>+ Package() { \_SB.PCI0.I2C3.CAM1, 0, 0 }<br>+ },<br>+ }<br>+ })<br>+}<br>diff --git a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl<br>index 8a9f166..d7534fe 100644<br>--- a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl<br>+++ b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl<br>@@ -58,6 +58,46 @@<br> )<br> })<br> <br>+ /* Port0 of CAM0 is connected to port0 of CIO2 device */<br>+ Name (_DSD, Package () {<br>+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br>+ Package () {<br>+ Package () { "port0", "PRT0" },<br>+ },<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "clock-frequency", 19200000 },<br>+ }<br>+ })<br>+<br>+ Name (PRT0, Package() {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "port", 0 },<br>+ },<br>+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br>+ Package () {<br>+ Package () { "endpoint0", "EP00" },<br>+ }<br>+ })<br>+<br>+ Name (EP00, Package() {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "endpoint", 0 },<br>+ Package () { "clock-lanes", 0 },<br>+ Package () { "data-lanes",<br>+ Package () { 1, 2, 3, 4 }<br>+ },<br>+ Package () { "link-frequencies",<br>+ Package() { 1190400000, 640000000 }<br>+ },<br>+ Package () { "remote-endpoint",<br>+ Package() { \_SB.PCI0.CIO2, 0, 0 }<br>+ },<br>+ }<br>+ })<br>+<br> Method (SSDB, 0, Serialized)<br> {<br> Return (Buffer (0x5E)<br>@@ -145,6 +185,46 @@<br> )<br> })<br> <br>+ /* Port0 of CAM1 is connected to port1 of CIO2 device */<br>+ Name (_DSD, Package () {<br>+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br>+ Package () {<br>+ Package () { "port0", "PRT0" },<br>+ },<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "clock-frequency", 19200000 },<br>+ }<br>+ })<br>+<br>+ Name (PRT0, Package() {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "port", 0 },<br>+ },<br>+ ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br>+ Package () {<br>+ Package () { "endpoint0", "EP00" },<br>+ }<br>+ })<br>+<br>+ Name (EP00, Package() {<br>+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br>+ Package () {<br>+ Package () { "endpoint", 0 },<br>+ Package () { "clock-lanes", 0 },<br>+ Package () { "data-lanes",<br>+ Package () { 1, 2 }<br>+ },<br>+ Package () { "link-frequencies",<br>+ Package() { 844800000 }<br>+ },<br>+ Package () { "remote-endpoint",<br>+ Package() { \_SB.PCI0.CIO2, 1, 0 }<br>+ },<br>+ }<br>+ })<br>+<br> Method (SSDB, 0, Serialized)<br> {<br> Return (Buffer (0x5E)<br>diff --git a/src/mainboard/intel/kblrvp/dsdt.asl b/src/mainboard/intel/kblrvp/dsdt.asl<br>index 2ce020c..870a147 100644<br>--- a/src/mainboard/intel/kblrvp/dsdt.asl<br>+++ b/src/mainboard/intel/kblrvp/dsdt.asl<br>@@ -45,8 +45,8 @@<br> }<br> <br> /* MIPI camera */<br>+ #include "acpi/ipu_mainboard.asl"<br> #include "acpi/mipi_camera.asl"<br>-<br> <br> #if IS_ENABLED(CONFIG_CHROMEOS)<br> // Chrome OS specific<br></pre><p>To view, visit <a href="https://review.coreboot.org/20662">change 20662</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20662"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If328864dbb61586a4887c7fcae740a12eda7cc92 </div>
<div style="display:none"> Gerrit-Change-Number: 20662 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: V Sowmya <v.sowmya@intel.com> </div>