<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20608">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sb/amd/cs5536 platforms: Remove extra #includes from ronstage.c<br><br>After removing the early_setup and early_smbus C files, these<br><br>Change-Id: I4d1fe5f775a255099965cac46bdbad2083337aa9<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/aaeon/pfm-540i_revb/romstage.c<br>M src/mainboard/amd/db800/romstage.c<br>M src/mainboard/amd/f2950/romstage.c<br>M src/mainboard/amd/norwich/romstage.c<br>M src/mainboard/amd/rumba/romstage.c<br>M src/mainboard/artecgroup/dbe61/romstage.c<br>M src/mainboard/digitallogic/msm800sev/romstage.c<br>M src/mainboard/iei/pcisa-lx-800-r10/romstage.c<br>M src/mainboard/iei/pm-lx-800-r11/romstage.c<br>M src/mainboard/iei/pm-lx2-800-r10/romstage.c<br>M src/mainboard/lippert/hurricane-lx/romstage.c<br>M src/mainboard/lippert/literunner-lx/romstage.c<br>M src/mainboard/lippert/roadrunner-lx/romstage.c<br>M src/mainboard/lippert/spacerunner-lx/romstage.c<br>M src/mainboard/pcengines/alix1c/romstage.c<br>M src/mainboard/pcengines/alix2d/romstage.c<br>M src/mainboard/traverse/geos/romstage.c<br>M src/mainboard/winent/pl6064/romstage.c<br>M src/mainboard/wyse/s50/romstage.c<br>19 files changed, 0 insertions(+), 121 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/20608/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/aaeon/pfm-540i_revb/romstage.c b/src/mainboard/aaeon/pfm-540i_revb/romstage.c<br>index 7efd988..9dd96f2 100644<br>--- a/src/mainboard/aaeon/pfm-540i_revb/romstage.c<br>+++ b/src/mainboard/aaeon/pfm-540i_revb/romstage.c<br>@@ -17,15 +17,8 @@<br> <br> /* Based on romstage.c from AMD's DB800 mainboard. */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <superio/smsc/smscsuperio/smscsuperio.h><br>diff --git a/src/mainboard/amd/db800/romstage.c b/src/mainboard/amd/db800/romstage.c<br>index 5ebc76d..69cca43 100644<br>--- a/src/mainboard/amd/db800/romstage.c<br>+++ b/src/mainboard/amd/db800/romstage.c<br>@@ -14,15 +14,9 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br> #include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/amd/f2950/romstage.c b/src/mainboard/amd/f2950/romstage.c<br>index 341a8ea..31bd266 100644<br>--- a/src/mainboard/amd/f2950/romstage.c<br>+++ b/src/mainboard/amd/f2950/romstage.c<br>@@ -14,15 +14,8 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/amd/norwich/romstage.c b/src/mainboard/amd/norwich/romstage.c<br>index 288a647..84b06d3 100644<br>--- a/src/mainboard/amd/norwich/romstage.c<br>+++ b/src/mainboard/amd/norwich/romstage.c<br>@@ -14,15 +14,9 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br> #include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <northbridge/amd/lx/raminit.h><br>diff --git a/src/mainboard/amd/rumba/romstage.c b/src/mainboard/amd/rumba/romstage.c<br>index 4d9600a..451ef72 100644<br>--- a/src/mainboard/amd/rumba/romstage.c<br>+++ b/src/mainboard/amd/rumba/romstage.c<br>@@ -11,11 +11,7 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <device/pci_def.h><br> #include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <superio/winbond/common/winbond.h><br> #include <superio/winbond/w83627hf/w83627hf.h><br> #include <cpu/x86/bist.h><br>diff --git a/src/mainboard/artecgroup/dbe61/romstage.c b/src/mainboard/artecgroup/dbe61/romstage.c<br>index 215d0d9..a7acd5c 100644<br>--- a/src/mainboard/artecgroup/dbe61/romstage.c<br>+++ b/src/mainboard/artecgroup/dbe61/romstage.c<br>@@ -14,15 +14,9 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <device/pci_def.h><br> #include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <stdlib.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include "spd_table.h"<br> #include <spd.h><br>diff --git a/src/mainboard/digitallogic/msm800sev/romstage.c b/src/mainboard/digitallogic/msm800sev/romstage.c<br>index 81975cf..df462e0 100644<br>--- a/src/mainboard/digitallogic/msm800sev/romstage.c<br>+++ b/src/mainboard/digitallogic/msm800sev/romstage.c<br>@@ -11,16 +11,8 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/car.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/iei/pcisa-lx-800-r10/romstage.c b/src/mainboard/iei/pcisa-lx-800-r10/romstage.c<br>index f5d5de4..a33b41d 100644<br>--- a/src/mainboard/iei/pcisa-lx-800-r10/romstage.c<br>+++ b/src/mainboard/iei/pcisa-lx-800-r10/romstage.c<br>@@ -14,16 +14,9 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br> #include <cpu/amd/car.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/iei/pm-lx-800-r11/romstage.c b/src/mainboard/iei/pm-lx-800-r11/romstage.c<br>index 52936ad..10d9eaf 100644<br>--- a/src/mainboard/iei/pm-lx-800-r11/romstage.c<br>+++ b/src/mainboard/iei/pm-lx-800-r11/romstage.c<br>@@ -15,15 +15,9 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdlib.h><br> #include <spd.h><br>-#include <arch/io.h><br>-#include <device/pci_def.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <superio/winbond/common/winbond.h><br> #include <superio/winbond/w83627ehg/w83627ehg.h><br>diff --git a/src/mainboard/iei/pm-lx2-800-r10/romstage.c b/src/mainboard/iei/pm-lx2-800-r10/romstage.c<br>index 3ea6013..6729e44 100644<br>--- a/src/mainboard/iei/pm-lx2-800-r10/romstage.c<br>+++ b/src/mainboard/iei/pm-lx2-800-r10/romstage.c<br>@@ -15,17 +15,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br> #include <spd.h><br>-#include <arch/io.h><br>-#include <device/pci_def.h><br> #include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br> #include <cpu/amd/car.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <superio/smsc/smscsuperio/smscsuperio.h><br> #include <northbridge/amd/lx/raminit.h><br>diff --git a/src/mainboard/lippert/hurricane-lx/romstage.c b/src/mainboard/lippert/hurricane-lx/romstage.c<br>index 2647ec8..e35fcf2 100644<br>--- a/src/mainboard/lippert/hurricane-lx/romstage.c<br>+++ b/src/mainboard/lippert/hurricane-lx/romstage.c<br>@@ -17,15 +17,8 @@<br> <br> /* Based on romstage.c from the SpaceRunner-LX mainboard. */<br> <br>-#include <stdlib.h><br>-#include <stdint.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <southbridge/amd/cs5536/smbus.h><br> #include <spd.h><br>diff --git a/src/mainboard/lippert/literunner-lx/romstage.c b/src/mainboard/lippert/literunner-lx/romstage.c<br>index e36d4ca..b415629 100644<br>--- a/src/mainboard/lippert/literunner-lx/romstage.c<br>+++ b/src/mainboard/lippert/literunner-lx/romstage.c<br>@@ -17,16 +17,9 @@<br> <br> /* Based on romstage.c from the SpaceRunner-LX mainboard. */<br> <br>-#include <stdlib.h><br>-#include <stdint.h><br> #include <spd.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <southbridge/amd/cs5536/smbus.h><br> #include <superio/ite/common/ite.h><br>diff --git a/src/mainboard/lippert/roadrunner-lx/romstage.c b/src/mainboard/lippert/roadrunner-lx/romstage.c<br>index 65ddcb7..5396d6b 100644<br>--- a/src/mainboard/lippert/roadrunner-lx/romstage.c<br>+++ b/src/mainboard/lippert/roadrunner-lx/romstage.c<br>@@ -17,15 +17,8 @@<br> <br> /* Based on romstage.c from AMD's DB800 and DBM690T mainboards. */<br> <br>-#include <stdlib.h><br>-#include <stdint.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <superio/ite/common/ite.h><br>diff --git a/src/mainboard/lippert/spacerunner-lx/romstage.c b/src/mainboard/lippert/spacerunner-lx/romstage.c<br>index 897de07..71a6446 100644<br>--- a/src/mainboard/lippert/spacerunner-lx/romstage.c<br>+++ b/src/mainboard/lippert/spacerunner-lx/romstage.c<br>@@ -17,16 +17,9 @@<br> <br> /* Based on romstage.c from AMD's DB800 and DBM690T mainboards. */<br> <br>-#include <stdlib.h><br>-#include <stdint.h><br> #include <spd.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <southbridge/amd/cs5536/smbus.h><br> #include <superio/ite/common/ite.h><br>diff --git a/src/mainboard/pcengines/alix1c/romstage.c b/src/mainboard/pcengines/alix1c/romstage.c<br>index 962e15d..1a5a1a4 100644<br>--- a/src/mainboard/pcengines/alix1c/romstage.c<br>+++ b/src/mainboard/pcengines/alix1c/romstage.c<br>@@ -13,17 +13,10 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br> #include <spd.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <lib.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <cpu/amd/car.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <northbridge/amd/lx/raminit.h><br>diff --git a/src/mainboard/pcengines/alix2d/romstage.c b/src/mainboard/pcengines/alix2d/romstage.c<br>index 750f755..06bc3af 100644<br>--- a/src/mainboard/pcengines/alix2d/romstage.c<br>+++ b/src/mainboard/pcengines/alix2d/romstage.c<br>@@ -13,17 +13,11 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br> #include <spd.h><br>-#include <device/pci_def.h><br> #include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <lib.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <cpu/amd/car.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <northbridge/amd/lx/raminit.h><br>diff --git a/src/mainboard/traverse/geos/romstage.c b/src/mainboard/traverse/geos/romstage.c<br>index a0c1e17..3f3ed3d 100644<br>--- a/src/mainboard/traverse/geos/romstage.c<br>+++ b/src/mainboard/traverse/geos/romstage.c<br>@@ -14,16 +14,10 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br> #include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <lib.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <northbridge/amd/lx/raminit.h><br>diff --git a/src/mainboard/winent/pl6064/romstage.c b/src/mainboard/winent/pl6064/romstage.c<br>index 624163b..2350628 100644<br>--- a/src/mainboard/winent/pl6064/romstage.c<br>+++ b/src/mainboard/winent/pl6064/romstage.c<br>@@ -15,16 +15,9 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <stdlib.h><br>-#include <device/pci_def.h><br>-#include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <lib.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br>-#include <cpu/amd/lxdef.h><br> #include <southbridge/amd/cs5536/cs5536.h><br> #include <spd.h><br> #include <superio/winbond/common/winbond.h><br>diff --git a/src/mainboard/wyse/s50/romstage.c b/src/mainboard/wyse/s50/romstage.c<br>index 8fc797c..7050298 100644<br>--- a/src/mainboard/wyse/s50/romstage.c<br>+++ b/src/mainboard/wyse/s50/romstage.c<br>@@ -14,11 +14,7 @@<br>  * GNU General Public License for more details.<br>  */<br> <br>-#include <stdint.h><br>-#include <device/pci_def.h><br> #include <arch/io.h><br>-#include <device/pnp_def.h><br>-#include <console/console.h><br> #include <lib.h><br> #include <cpu/x86/bist.h><br> #include <cpu/x86/msr.h><br></pre><p>To view, visit <a href="https://review.coreboot.org/20608">change 20608</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20608"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4d1fe5f775a255099965cac46bdbad2083337aa9 </div>
<div style="display:none"> Gerrit-Change-Number: 20608 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>