<p>Patrick Rudolph <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/20394">View Change</a></p><p>Patch set 1:</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/20394/1/src/drivers/intel/gma/opregion.c">File src/drivers/intel/gma/opregion.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20394/1/src/drivers/intel/gma/opregion.c@101">Patch Set #1, Line 101:</a> <code style="font-family:monospace,monospace">init_igd_opregion(igd_opregion_t *opregion)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please use the naming scheme: intel_gma_init_igd_opregion.<br>This would make clear where the code resides and it prevents conflicts with existing implementations.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20394/1/src/drivers/intel/gma/opregion.c@132">Patch Set #1, Line 132:</a> <code style="font-family:monospace,monospace">          optionrom_header_t *oprom = (optionrom_header_t *) pci_rom_probe(dev_find_slot(0, PCI_DEVFN(0x2,0)));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">character line limit</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20394/1/src/drivers/intel/gma/opregion.c@153">Patch Set #1, Line 153:</a> <code style="font-family:monospace,monospace">  if (!vbt)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Always false, as vbt is set to &fake_vbt</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/20394/1/src/drivers/intel/gma/opregion.c@168">Patch Set #1, Line 168:</a> <code style="font-family:monospace,monospace">                      rdev_munmap(&vbt_rdev, vbt);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">if (need_unmap) ...</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/20394">change 20394</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20394"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2378043a82bdf785df10a702afef1123662e04d9 </div>
<div style="display:none"> Gerrit-Change-Number: 20394 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Jul 2017 16:51:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>