<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20540">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fsp1_1: Don't look for FSP_SMBIOS_MEMORY_INFO_HOB in S3 flow<br><br>FSP don't publish smbios_memory_info_guid during S3 resume<br>path. Hence its recommended to skip consuming this HOB in<br>S3 resume.<br><br>Bug=none<br>Branch=none<br>TEST=Build and boot Lars system with this patch.<br><br>Change-Id: I321751523b1ea3326ffc23f4d4c53d5362482674<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/drivers/intel/fsp1_1/romstage.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/20540/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c<br>index c2fc667..01f484e 100644<br>--- a/src/drivers/intel/fsp1_1/romstage.c<br>+++ b/src/drivers/intel/fsp1_1/romstage.c<br>@@ -101,6 +101,7 @@<br> /* Entry from the mainboard. */<br> void romstage_common(struct romstage_params *params)<br> {<br>+    bool s3wake;<br>  struct region_device rdev;<br>    struct pei_data *pei_data;<br> <br>@@ -110,9 +111,10 @@<br> <br>        pei_data = params->pei_data;<br>       pei_data->boot_mode = params->power_state->prev_sleep_state;<br>+        s3wake = params->power_state->prev_sleep_state == ACPI_S3;<br> <br> #if IS_ENABLED(CONFIG_ELOG_BOOT_COUNT)<br>- if (params->power_state->prev_sleep_state != ACPI_S3)<br>+  if (!s3wake)<br>          boot_count_increment();<br> #endif<br> <br>@@ -168,7 +170,8 @@<br>      }<br> <br>  /* Save DIMM information */<br>-  mainboard_save_dimm_info(params);<br>+    if (!s3wake)<br>+         mainboard_save_dimm_info(params);<br> <br>  /* Create romstage handof information */<br>      if (romstage_handoff_init(<br></pre><p>To view, visit <a href="https://review.coreboot.org/20540">change 20540</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20540"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I321751523b1ea3326ffc23f4d4c53d5362482674 </div>
<div style="display:none"> Gerrit-Change-Number: 20540 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>