<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20482">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/mec1308: Fix fan control ACPI<br><br>Returing FSL# for _STA causes Windows to BSOD. Re-work _STA to instead<br>return 0/1 based on FLVL, using google/beltino as a model.<br><br>Also correct serialization type for _CRS.<br><br>Change-Id: Ibf3af15bab3590f7c1c4401e1978dbcf2a495216<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/ec/smsc/mec1308/acpi/ec.asl<br>1 file changed, 36 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/20482/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/ec/smsc/mec1308/acpi/ec.asl b/src/ec/smsc/mec1308/acpi/ec.asl<br>index a8de9fa..697e4b1 100644<br>--- a/src/ec/smsc/mec1308/acpi/ec.asl<br>+++ b/src/ec/smsc/mec1308/acpi/ec.asl<br>@@ -58,7 +58,7 @@<br> FCOS, 1, // Fan Speed OS Control<br> }<br> <br>- Method (_CRS, 0, NotSerialized)<br>+ Method (_CRS, 0, Serialized)<br> {<br> Name (ECMD, ResourceTemplate()<br> {<br>@@ -87,7 +87,13 @@<br> <br> PowerResource (FNP0, 0, 0)<br> {<br>- Method (_STA) { Return (FSL0) }<br>+ Method (_STA) {<br>+ If (LLessEqual (\FLVL, 0)) {<br>+ Return (One)<br>+ } Else {<br>+ Return (Zero)<br>+ }<br>+ }<br> Method (_ON) {<br> If (FCOS) {<br> Store (One, FSL0)<br>@@ -106,7 +112,13 @@<br> <br> PowerResource (FNP1, 0, 0)<br> {<br>- Method (_STA) { Return (FSL1) }<br>+ Method (_STA) {<br>+ If (LLessEqual (\FLVL, 0)) {<br>+ Return (One)<br>+ } Else {<br>+ Return (Zero)<br>+ }<br>+ }<br> Method (_ON) {<br> If (FCOS) {<br> Store (One, FSL1)<br>@@ -125,7 +137,13 @@<br> <br> PowerResource (FNP2, 0, 0)<br> {<br>- Method (_STA) { Return (FSL2) }<br>+ Method (_STA) {<br>+ If (LLessEqual (\FLVL, 0)) {<br>+ Return (One)<br>+ } Else {<br>+ Return (Zero)<br>+ }<br>+ }<br> Method (_ON) {<br> If (FCOS) {<br> Store (One, FSL2)<br>@@ -144,7 +162,13 @@<br> <br> PowerResource (FNP3, 0, 0)<br> {<br>- Method (_STA) { Return (FSL3) }<br>+ Method (_STA) {<br>+ If (LLessEqual (\FLVL, 0)) {<br>+ Return (One)<br>+ } Else {<br>+ Return (Zero)<br>+ }<br>+ }<br> Method (_ON) {<br> If (FCOS) {<br> Store (One, FSL3)<br>@@ -163,7 +187,13 @@<br> <br> PowerResource (FNP4, 0, 0)<br> {<br>- Method (_STA) { Return (FSL4) }<br>+ Method (_STA) {<br>+ If (LLessEqual (\FLVL, 0)) {<br>+ Return (One)<br>+ } Else {<br>+ Return (Zero)<br>+ }<br>+ }<br> Method (_ON) {<br> If (FCOS) {<br> Store (One, FSL4)<br></pre><p>To view, visit <a href="https://review.coreboot.org/20482">change 20482</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20482"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibf3af15bab3590f7c1c4401e1978dbcf2a495216 </div>
<div style="display:none"> Gerrit-Change-Number: 20482 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>